Better catch when vcs programs not installed. #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if vcs commands exist before running commands. Cache the result so that the check doesn't happen for every file (if the user installs git or hg, they will need to restart runmanager or the compiler subprocess for saving of vcs info to start working). Should address labscript-suite/labscript-suite#66
|
Another old PR that should have been merged a long time ago. Looks fine to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if vcs commands exist before running commands. Cache the result so
that the check doesn't happen for every file (if the user installs git
or hg, they will need to restart runmanager or the compiler
subprocess for saving of vcs info to start working).
Should address labscript-suite/labscript-suite#66