Skip to content

Fix memory leak of h5py when accessing dataset with composite dtypes. #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Fix memory leak of h5py when accessing dataset with composite dtypes. #92

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions labscript_utils/properties.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ def _get_con_table_properties(h5_file, device_name):

# Compare with the name in the connection table
# whether it is np.bytes_ or vlenstr:
namecol_dtype = dataset['name'].dtype
namecol_dtype = dataset.dtype['name']
if namecol_dtype.type is np.bytes_:
device_name = device_name.encode('utf8')
elif namecol_dtype is h5py.special_dtype(vlen=str):
Expand All @@ -143,7 +143,7 @@ def _get_unit_conversion_parameters(h5_file, device_name):

# Compare with the name in the connection table
# whether it is np.bytes_ or vlenstr:
namecol_dtype = dataset['name'].dtype
namecol_dtype = dataset.dtype['name']
if namecol_dtype.type is np.bytes_:
device_name = device_name.encode('utf8')
elif namecol_dtype is h5py.special_dtype(vlen=str):
Expand Down