Declarative setup #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpanderson
commented
May 17, 2020
setup.cfg
Outdated
| license = BSD | ||
| classifiers = | ||
| License :: OSI Approved :: BSD License | ||
| Programming Language :: Python :: 2.7 |
There was a problem hiding this comment.
We should consistently remove 2.7 support. At the moment it's been dropped from lyse, runmanager, and runviewer.
rpanderson
commented
May 17, 2020
|
|
||
| if 'CONDA_BUILD' in os.environ: | ||
| if "CONDA_BUILD" in os.environ: |
There was a problem hiding this comment.
@chrisjbillington is there a reason this package doesn't override install_requires like the others?
There was a problem hiding this comment.
Don't remember, but probably because all of its dependencies have conda package (zprocess and qtutils on my personal conda repo, anyway). That makes me think I only ever overrode setup_requires for this reason, and that we should just not overwrite it and work on getting everything on conda.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces setup.cfg and makes setup.py as simple as possible, containing only programmatic overrides.
version_schemeandlocal_schemefor setuptools_scm, overridden by environment variablesSCM_VERSION_SCHEMEandSCM_LOCAL_SCHEME, respectively, in anticipation of automated release process. (Defaultversion_schemewill be updated torelease-branch-semverupon next release of setuptools_scm.)