TekScope bug fix #118
Merged
TekScope bug fix #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ock is blocking) and changed create_group to require_group to allow more than one process to work.
philipstarkey
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TekScope device had a bug where it was calling
hdf_file.create_group('/data/traces')in transition to manual. This is a problem because if you have two scopes this code fails the second time. Instead (and like the camera devices) I changed this togrp = hdf_file.require_group('/data/traces'). Trivial.Also in transition to buffered the code
self.scope.dev.timeout = 1000 * self.scope_params.get('timeout', 5)appeared while the h5 file was open (which was not needed). Moved this after closing the h5 file to slightly reduce the time that the file was locked.