feat(service): Add launchpad PVC query function and bug fix #6063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bearslyricattack
changed the title
bearslyricattack
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR adds PVC (Persistent Volume Claim) query functionality to the launchpad service and fixes metric query bugs for Kafka and Milvus services. The changes enable storage usage monitoring for applications deployed through the launchpad.
Key Changes
- Added PVC name parameter support to VMRequest struct and request parsing
- Added storage query capability for PVC usage monitoring
- Fixed Kafka and Milvus metric queries by correcting pod name regex patterns and adding Milvus query definitions
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
service/pkg/request/req.go |
Added Milvus case to query type switch statement |
service/pkg/api/req.go |
Added PvcName field to VMRequest struct and defined Milvus queries with corrected Kafka regex patterns |
service/launchpad/server/server.go |
Added pvcName parameter parsing in request handler |
service/launchpad/request/req.go |
Added storage query case and PVC name substitution logic |
service/launchpad/Makefile |
Added TARGETARCH variable definition |
zijiren233
approved these changes
Oct 9, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
zijiren233
force-pushed
the
monitor-fix
branch
from
07459ac to
02b1aff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PVC usage query function to the launch pad service.
Fixed the issue where VM was unable to correctly query Kafka and Milvus CPU memory metrics. This issue is only a preliminary fix and requires further correction in the future.