Devbox daemon #5709
Open
Devbox daemon #5709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whoa! Easy there, Partner!This PR is too big. Please break it up into smaller PRs. |
TestGru AssignmentSummary
Tip You can |
dinoallo
reviewed
Jul 21, 2025
| logger.Info( | ||
| "Devbox is shutdown, pod is deleted, commit devbox and create a new content id and new record", | ||
| "devboxName", devboxName) | ||
| devbox.Status.CommitRecords[devbox.Status.ContentID].CommitStatus = devboxv1alpha1.CommitStatusSuccess |
There was a problem hiding this comment.
Should CommitStatusSuccess be set after the commit actually being done successfully?
dinoallo
reviewed
Jul 21, 2025
| // Check if this is a devbox pod by looking for the devbox label, and the devbox is scheduled to the current node | ||
| if !r.isDevboxPod(pod) || r.getDevboxNameFromPod(pod) == "" || pod.Spec.NodeName != nodes.GetNodeName() { | ||
| return ctrl.Result{}, nil | ||
| } |
There was a problem hiding this comment.
This can also be rewritten as filters for pod CRUD events
dinoallo
reviewed
Jul 21, 2025
| // schedule devbox to node, update devbox status and create a new commit record | ||
| // and filter out the devbox that are not in the current node | ||
| if devbox.Status.CommitRecords[devbox.Status.ContentID].Node == "" { | ||
| // set up devbox node and content id, new a record for the devbox |
dinoallo
reviewed
Jul 21, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5709 +/- ##
=======================================
Coverage 61.97% 61.97%
=======================================
Files 8 8
Lines 647 647
=======================================
Hits 401 401
Misses 200 200
Partials 46 46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.