feat(system-server): add update function apis;

packages/system-server/src/router/function/index.ts

@@ -1,7 +1,7 @@
 /*
  * @Author: Maslow<wangfugen@126.com>
  * @Date: 2021-08-29 11:35:05
- * @LastEditTime: 2021-09-04 00:00:56
+ * @LastEditTime: 2021-09-05 02:41:42
  * @Description:
  */
 
@@ -11,6 +11,7 @@ import { handleGetFunctionById, handleGetFunctions } from "./get"
 import { handlePublishFunctions } from "./publish"
 import { handleRemoveFunctionById } from "./remove"
 import { handlePublishTriggers } from "./trigger"
+import { handleUpdateFunction, handleUpdateFunctionCode } from "./update"
 
 
 export const FunctionRouter = Router()
@@ -33,18 +34,29 @@ FunctionRouter.post('/create', handleCreateFunction)
 /**
  * Update the function's info except the codes & triggers
  */
-FunctionRouter.post('/:func_id/info')
+FunctionRouter.post('/:func_id/info', handleUpdateFunction)
 
 /**
  * Update the function's code
  */
-FunctionRouter.post('/:func_id/codes')
+FunctionRouter.post('/:func_id/code', handleUpdateFunctionCode)
 
 /**
  * Remove a function by id of an application
  */
 FunctionRouter.delete('/:func_id', handleRemoveFunctionById)
 
+/**
+ * Debug the function
+ */
+FunctionRouter.post('/:func_id/debug')
+
+/**
+ * Publish functions of the application
+ */
+FunctionRouter.post('/publish', handlePublishFunctions)
+
+
 /**
  * Create a trigger to the function
  */
@@ -56,14 +68,9 @@ FunctionRouter.post('/:func_id/triggers')
 FunctionRouter.post('/:func_id/triggers/:trigger_id')
 
 /**
- * Debug the function
+ * Remove a trigger of the function
  */
-FunctionRouter.post('/:func_id/debug')
-
-/**
- * Publish functions of the application
- */
-FunctionRouter.post('/publish', handlePublishFunctions)
+FunctionRouter.delete('/:func_id/triggers/:trigger_id')
 
 /**
  * Publish triggers of the application

packages/system-server/src/router/function/update.ts

@@ -0,0 +1,137 @@
+/*
+ * @Author: Maslow<wangfugen@126.com>
+ * @Date: 2021-09-05 02:11:39
+ * @LastEditTime: 2021-09-05 03:14:37
+ * @Description: 
+ */
+
+
+import { compileTs2js } from 'cloud-function-engine/dist/utils'
+import { Request, Response } from 'express'
+import { ObjectId } from 'mongodb'
+import { ApplicationStruct } from '../../api/application'
+import { checkPermission } from '../../api/permission'
+import { Constants } from '../../constants'
+import { permissions } from '../../constants/permissions'
+import { DatabaseAgent } from '../../lib/db-agent'
+import { hashFunctionCode } from '../../utils/hash'
+
+const { FUNCTION_UPDATE } = permissions
+
+/**
+ * Update function's basic info
+ */
+export async function handleUpdateFunction(req: Request, res: Response) {
+  const uid = req['auth']?.uid
+  const db = DatabaseAgent.sys_db
+  const app: ApplicationStruct = req['parsed-app']
+  const func_id = req.params.func_id
+
+  // check permission
+  const code = await checkPermission(uid, FUNCTION_UPDATE.name, app)
+  if (code) {
+    return res.status(code).send()
+  }
+
+  const body = req.body
+
+  // function name should be unique
+  if (body.name) {
+    const total = await DatabaseAgent.sys_accessor.db.collection(Constants.cn.functions)
+      .countDocuments({
+        _id: {
+          $ne: new ObjectId(func_id)
+        },
+        name: body.name,
+        appid: app.appid
+      })
+
+    if (total) return res.status(422).send('function name already exists')
+  }
+
+  const { data: func } = await db.collection(Constants.cn.functions)
+    .where({ _id: func_id, appid: app.appid })
+    .getOne()
+
+  if (!func) return res.status(422).send('function not found')
+
+  // build the func data
+  const data = {
+    name: body.name ?? func.name,
+    description: body.description ?? func.description,
+    enableHTTP: body.enableHTTP ?? func.enableHTTP,
+    status: body.status ?? func.status,
+    tags: body.tags ?? func.tags,
+    label: body.label ?? func.label,
+    updated_at: Date.now()
+  }
+
+  // add cloud function
+  const ret = await db.collection(Constants.cn.functions)
+    .where({ _id: func_id, appid: app.appid })
+    .update(data)
+
+  if (ret.error) {
+    return res.status(400).send({ error: ret.error })
+  }
+
+  return res.send({ data: ret })
+}
+
+
+/**
+ * Update function's code
+ */
+export async function handleUpdateFunctionCode(req: Request, res: Response) {
+  const uid = req['auth']?.uid
+  const db = DatabaseAgent.sys_db
+  const app: ApplicationStruct = req['parsed-app']
+  const func_id = req.params.func_id
+
+  // check permission
+  const code = await checkPermission(uid, FUNCTION_UPDATE.name, app)
+  if (code) {
+    return res.status(code).send()
+  }
+
+  const body = req.body
+  if (!body.code) return res.status(422).send('code cannot be empty')
+
+  const { data: func } = await db.collection(Constants.cn.functions)
+    .where({ _id: func_id, appid: app.appid })
+    .getOne()
+
+  if (!func) return res.status(422).send('function not found')
+
+  // build the func data
+  const data = {
+    code: body.code,
+    compiledCode: compileTs2js(body.code),
+    version: func.version++,
+    hash: hashFunctionCode(body.code),
+    debugParams: body.debugParams || func.debugParams,
+    updated_at: Date.now()
+  }
+
+  // record the function change history
+  if (data.hash !== func.hash) {
+    const record = Object.assign({}, func)
+    await db.collection(Constants.cn.function_history)
+      .add({
+        func_id: func._id,
+        data: record,
+        created_at: Date.now()
+      })
+  }
+
+  // update cloud function
+  const ret = await db.collection(Constants.cn.functions)
+    .where({ _id: func_id, appid: app.appid })
+    .update(data)
+
+  if (ret.error) {
+    return res.status(400).send({ error: ret.error })
+  }
+
+  return res.send({ data: ret })
+}