fix(server): fix error log in server (#505)

Signed-off-by: maslow <wangfugen@126.com>
labring · Dec 9, 2022 · 7eaefd5 · 7eaefd5
1 parent 805f6b6
commit 7eaefd5
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 12 deletions.
diff --git a/server/src/applications/application-task.service.ts b/server/src/applications/application-task.service.ts
@@ -130,5 +130,6 @@ export class ApplicationTaskService {
         phase: ApplicationPhase.Deleted,
       },
     })
+    this.logger.log(`Application ${app.appid} updated to phase deleted`)
   }
 }
diff --git a/server/src/core/application.cr.service.ts b/server/src/core/application.cr.service.ts
@@ -35,6 +35,7 @@ export class ApplicationCoreService {
       const res = await this.k8sClient.coreV1Api.readNamespace(namespace)
       return res.body
     } catch (err) {
+      if (err?.response?.body?.reason === 'NotFound') return null
       this.logger.error(err)
       return null
     }

diff --git a/server/src/core/database.cr.service.ts b/server/src/core/database.cr.service.ts
@@ -79,11 +79,9 @@ export class DatabaseCoreService {
         )
       return Database.fromObject(res.body)
     } catch (err) {
+      if (err?.response?.body?.reason === 'NotFound') return null
       this.logger.error(err)
-      if (err?.response?.body?.reason === 'NotFound') {
-        return null
-      }
-      throw err
+      return null
     }
   }
 

diff --git a/server/src/core/gateway.cr.service.ts b/server/src/core/gateway.cr.service.ts
@@ -45,11 +45,9 @@ export class GatewayCoreService {
         )
       return Gateway.fromObject(res.body)
     } catch (err) {
+      if (err?.response?.body?.reason === 'NotFound') return null
       this.logger.error(err)
-      if (err?.response?.body?.reason === 'NotFound') {
-        return null
-      }
-      throw err
+      return null
     }
   }
 

diff --git a/server/src/core/oss-user.cr.service.ts b/server/src/core/oss-user.cr.service.ts
@@ -64,11 +64,9 @@ export class OSSUserCoreService {
         )
       return OSSUser.fromObject(res.body)
     } catch (err) {
+      if (err?.response?.body?.reason === 'NotFound') return null
       this.logger.error(err)
-      if (err?.response?.body?.reason === 'NotFound') {
-        return null
-      }
-      throw err
+      return null
     }
   }
 

diff --git a/server/src/instance/instance-task.service.ts b/server/src/instance/instance-task.service.ts
@@ -88,6 +88,7 @@ export class InstanceTaskService {
             phase: ApplicationPhase.Started,
           },
         })
+        this.logger.debug(`Application ${app.appid} updated to phase started`)
       } catch (error) {
         this.logger.error(error)
       }

diff --git a/server/src/instance/instance.service.ts b/server/src/instance/instance.service.ts
@@ -215,6 +215,7 @@ export class InstanceService {
       )
       return res.body
     } catch (error) {
+      if (error?.response?.body?.reason === 'NotFound') return null
       return null
     }
   }