-
Notifications
You must be signed in to change notification settings - Fork 6.9k
perf: remove request invalid field #6283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| --- | ||
| title: 'V4.14.5' | ||
| title: 'V4.14.5(包含升级脚本)' | ||
| description: 'FastGPT V4.14.5 更新说明' | ||
| --- | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -230,6 +230,9 @@ export const loadRequestMessages = async ({ | |||
| const result = ( | ||||
| await Promise.all( | ||||
| content.map(async (item) => { | ||||
| // Remove system filed | ||||
|
|
||||
|
||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S3 key deleted before image loading can use it
High Severity
The delete item.key statement removes the key property before loadUserContentImage is called. However, loadUserContentImage relies on item.key at line 172 to fetch image URLs from S3 storage via getS3ChatSource().createGetChatFileURL(). Since the key is deleted beforehand, the S3 lookup path will never be taken, breaking image loading for S3-stored images when content is an array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment contains a spelling error. "filed" should be "field".