Repository navigation
update: set prompt-lookup defaults from the GB10 measurement - #2265
Merged
Merged
Conversation
Record the end-of-run measurement for #2229 and #2255 and settle the two values #2255 left provisional. PROMPT_LOOKUP_PAGED_CONTEXT_LIMIT becomes 4096: on paged storage the flag still gains at 4096 tokens (1.42x copy, 1.12x open question) and loses at 8192 (0.62x on the open question). DEFAULT_PROMPT_LOOKUP_MAX_BATCH stays 2: a gate of 8 loses 13 percent on the chat-template copy workload at concurrency 4. The measurement also shows the flag costs 3.5 percent on chat replies that copy little, which misses #2255's -1.0 percent criterion; the docs and changelog say so, and #2264 tracks gating those rounds off.
9 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
End-of-run measurement for #2229 (PR #2256) and #2255 (PR #2262) on GB10, and the two values #2255 left provisional, now set from it. Report:
docs/benchmark_results/server-prompt-lookup-gb10-2026-10-11.md; drivers, raw output and analysis script underdocs/benchmark_results/data/server-prompt-lookup-gb10-2026-10-11/.PROMPT_LOOKUP_PAGED_CONTEXT_LIMIT:NonetoSome(4096). A paged sequence stops running verify rounds past 4096 tokens of context and decodes plainly.DEFAULT_PROMPT_LOOKUP_MAX_BATCH: stays 2; the doc comment and the--prompt-lookup-max-batchhelp now cite the measurement instead of calling it provisional.docs/CONTINUOUS_BATCHING.mdand the CHANGELOG entry state the measured gains and the cost on low-copy chat, and point to perf: stop server prompt-lookup rounds that cost more than they emit #2264.Results
#2229, penalty requests on the CLI path (
--repetition-penalty 1.1, 5 rounds with a null arm): against main before #2229 the engine client now decodes 23 % (Qwen3-1.7B, 256 tokens), 16 % (Qwen3, 8192), 31 % (Llama-3.2-1B, 256) and 23 % (Llama, 8192) faster, every round above every round. Against the pre-epicCxxGenerator(4c44e317) it is equal on Qwen3 at 256 tokens (inside the null range) and 1.5 to 2.7 % faster in the other three cells.#2255, server prompt lookup (Qwen3-1.7B, 256 tokens):
The flag is opt-in, so decode without it is unchanged.
Test plan
--profile test-fast --features cuda --lib --tests --bins -D warnings--lib server::batch(526),server::speculative_dispatch(17),--test cli_help_consistency(27),--test dead_doc_pointers, Apache header check, all undergpu-lockwith--test-threads=1scripts/ci/check_binary_assets.pyfails on main's two undeclared tarballs from test(rocm): verify the unified engine on gfx1151 after the engine epic #2250 (docs/benchmark_results/data/rocm-unified-engine-gfx1151-2026-10-08/); this PR adds no binary fileRefs #2229, #2255, #2264