Skip to content

feat(BA-513): implement an API for generating JWT in manager #3673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: feature/downloading-multi-files
Choose a base branch
from

Conversation

nowgnuesLee
Copy link

@nowgnuesLee nowgnuesLee commented Feb 12, 2025

resolves #3444 (BA-513)

changes

  • Implemented a new API for generating JWT in manager with zip_name, files, format

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue

📚 Documentation preview 📚: https://sorna--3673.org.readthedocs.build/en/3673/


📚 Documentation preview 📚: https://sorna-ko--3673.org.readthedocs.build/ko/3673/

@github-actions github-actions bot added comp:manager Related to Manager component size:M 30~100 LoC area:docs Documentations size:L 100~500 LoC and removed size:M 30~100 LoC labels Feb 12, 2025
@nowgnuesLee nowgnuesLee marked this pull request as ready for review February 12, 2025 08:09
@github-actions github-actions bot added comp:agent Related to Agent component comp:client Related to Client component comp:common Related to Common component comp:webserver Related to Web Server component comp:installer Related to Installer comp:storage-proxy Related to Storage proxy component require:db-migration Automatically set when alembic migrations are added or updated labels Feb 19, 2025
@nowgnuesLee nowgnuesLee force-pushed the feature/implement-download-api-manager branch from c0feff2 to 9481bbf Compare February 19, 2025 09:07
@github-actions github-actions bot added size:M 30~100 LoC and removed size:L 100~500 LoC labels Feb 19, 2025
Co-authored-by: octodog <mu001@lablup.com>
@github-actions github-actions bot added size:L 100~500 LoC and removed size:M 30~100 LoC labels Feb 19, 2025
@@ -3616,6 +3675,7 @@ def create_app(default_cors_options):
cors.add(add_route("POST", r"/{name}/mkdir", mkdir))
cors.add(add_route("POST", r"/{name}/request-upload", create_upload_session))
cors.add(add_route("POST", r"/{name}/request-download", create_download_session))
cors.add(add_route("POST", r"/{name}/download", download))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

download-multi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Documentations comp:agent Related to Agent component comp:client Related to Client component comp:common Related to Common component comp:installer Related to Installer comp:manager Related to Manager component comp:storage-proxy Related to Storage proxy component comp:webserver Related to Web Server component require:db-migration Automatically set when alembic migrations are added or updated size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants