Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup: Upgrade hiredis to 2.2.1 #1025

Merged
merged 12 commits into from
Feb 28, 2023
Merged

setup: Upgrade hiredis to 2.2.1 #1025

merged 12 commits into from
Feb 28, 2023

Conversation

studioego
Copy link
Contributor

setup: Upgrade hiredis to 2.2.1

  • support some wheels for old gcc versions and multi-platform wheels

resolves #1024

See details

@studioego
setup: Upgrade hiredis to 2.2.1
e722c15 
setup: Upgrade hiredis to 2.2.1
 - support some wheels for old gcc versions and multi-platform wheels
@studioego studioego added comp:installer Related to Installer effort:easy Need to understand only a specific region of codes (good first issue, easy). type:refactor Refactor codes or add tests. type:enhance Enhance component, behavior, internals without user-facing features labels Feb 8, 2023
@studioego studioego self-assigned this Feb 8, 2023
@github-actions github-actions bot added the type:maintenance Maintenance issue. label Feb 8, 2023
@studioego
Copy link
Contributor Author

I installed new CentOS7 image and Backend.AI on new CentOS7 image.

image
image

It works correctly on both CentOS7 and CentOS8(Also, I checked MacOS M1(arm64) and Fedora core 37(x86_64)

kyujin-cho
kyujin-cho requested changes Feb 13, 2023
View reviewed changes
Copy link
Member

@kyujin-cho kyujin-cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked about the changes made to hiredis when they upgrade major version to 2? I'm frustrated that this might potentially break our code. Please let me know.

@achimnol
Copy link
Member

Have you checked about the changes made to hiredis when they upgrade major version to 2? I'm frustrated that this might potentially break our code. Please let me know.

hiredis is used by redis-py as an internal parser replacement to accelerate its base implementation written in Python. It should have no impacts to our codes.

@achimnol achimnol added this pull request to the merge queue Feb 28, 2023
Merged via the queue into main with commit c6ec366 Feb 28, 2023
@achimnol achimnol deleted the feature/upgrade_hiredis_to_2_2_1 branch February 28, 2023 02:35
@Yaminyam Yaminyam added the size:L 100~500 LoC label Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyujin-cho kyujin-cho kyujin-cho requested changes

@achimnol achimnol Awaiting requested review from achimnol

Assignees

@studioego studioego

Labels
comp:installer Related to Installer effort:easy Need to understand only a specific region of codes (good first issue, easy). size:L 100~500 LoC type:enhance Enhance component, behavior, internals without user-facing features type:maintenance Maintenance issue. type:refactor Refactor codes or add tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade hiredis to 2.2.1
4 participants
@studioego @achimnol @kyujin-cho @Yaminyam