fix(FR-1876): remove unnecessary filter for resource usage values in MyResourceWithinResourceGroup #4951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in resource display by removing an unnecessary filter that was hiding valid accelerator resource states from users.
Key Changes:
- Removed filter logic that excluded accelerators when both
usedandremainingvalues were 0 or non-finite (Infinity)
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.91% | 589/11988 |
| 🔴 | Branches | 4.47% (+0% 🔼) |
377/8425 |
| 🔴 | Functions | 2.75% | 101/3676 |
| 🔴 | Lines | 4.74% (+0% 🔼) |
555/11706 |
Test suite run success
173 tests passing in 13 suites.
Report generated by 🧪jest coverage report action from d43b6ed
jopemachine
approved these changes
Jan 6, 2026
agatha197
force-pushed
the
fix_FR-1876_/remove-unnecessary-filter
branch
from
c64ad7c to
c777403
Compare
5 tasks
agatha197
force-pushed
the
fix_FR-1876_/remove-unnecessary-filter
branch
from
c777403 to
4162ce2
Compare
…MyResourceWithinResourceGroup
agatha197
force-pushed
the
fix_FR-1876_/remove-unnecessary-filter
branch
from
4162ce2 to
d43b6ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4952 (FR-1876)
Improved Resource Slot Filtering Logic
This PR refines the filtering logic for resource slots in the
MyResourceWithinResourceGroupcomponent. Previously, slots were hidden when bothusingCurrentandremainingCurrentvalues were zero or not finite. The updated logic now only hides resource slots when both values are not finite numbers, allowing slots with zero values to be displayed.Checklist: