feat(FR-1688): custom logo path setting and preview feature #4837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:ux
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
3 tasks
Contributor
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.23% | 496/11718 |
| 🔴 | Branches | 3.66% | 298/8149 |
| 🔴 | Functions | 2.55% | 92/3604 |
| 🔴 | Lines | 4.21% | 482/11460 |
Test suite run success
144 tests passing in 13 suites.
Report generated by 🧪jest coverage report action from b46ac74
ironAiken2
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a comprehensive logo customization feature to the User Settings page, enabling users to customize WebUI logos for different display modes (light/dark) and sidebar states (expanded/collapsed).
Key Changes
- New
LogoPreviewercomponent that handles logo uploads (max 2MB) and path inputs with real-time preview - Logo preview functionality via a separate window that uses sessionStorage flags and localStorage event listeners
- Integration with existing theme customization system, storing logos as base64 in localStorage
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| resources/i18n/*.json | Added translations for logo customization UI in 18 languages including section titles, descriptions, and field labels |
| react/src/hooks/useBAISetting.tsx | Extended UserSettings interface with preview_logo_path field of type PreviewLogoConfig |
| react/src/components/MainLayout/WebUISider.tsx | Added preview mode detection, localStorage event listener for cross-window updates, and conditional logo rendering based on theme and preview mode |
| react/src/components/BrandingSettingList.tsx | Added logo customization section with 4 logo variants, moved preview button to extraButton prop, and implemented logo-specific reset logic |
| react/src/components/BrandingSettingItems/LogoPreviewer.tsx | New component implementing file upload with size validation, path input with debouncing, and integration with theme config system |
ironAiken2
force-pushed
the
feat/FR-1688-custom-logo-setting
branch
2 times, most recently
from
8ef4a66 to
2a6d699
Compare
nowgnuesLee
requested changes
Dec 17, 2025
Contributor
nowgnuesLee
left a comment
nowgnuesLee
left a comment
There was a problem hiding this comment.
I think the PR title should be changed from maintenance page to configuration page.
react/src/components/BrandingSettingItems/EditableImagePath.tsx
Outdated
Show resolved
Hide resolved
ironAiken2
force-pushed
the
feat/FR-1688-custom-logo-setting
branch
from
2a6d699 to
552ca29
Compare
ironAiken2
changed the base branch from
feat/FR-1720-theme-color-reset
to
graphite-base/4837
ironAiken2
force-pushed
the
graphite-base/4837
branch
from
a9a7a71 to
173bd7a
Compare
ironAiken2
force-pushed
the
feat/FR-1688-custom-logo-setting
branch
from
552ca29 to
7b7f2e2
Compare
ironAiken2
changed the base branch from
graphite-base/4837
to
refactor/remove-setvalue-of-setting-item
yomybaby
changed the base branch from
refactor/remove-setvalue-of-setting-item
to
graphite-base/4837
ironAiken2
force-pushed
the
graphite-base/4837
branch
from
173bd7a to
6462708
Compare
ironAiken2
force-pushed
the
feat/FR-1688-custom-logo-setting
branch
from
7b7f2e2 to
08433d3
Compare
5 tasks
ironAiken2
force-pushed
the
feat/FR-1688-custom-logo-setting
branch
from
08433d3 to
44e7f6d
Compare
ironAiken2
changed the title
ironAiken2
force-pushed
the
feat/FR-1688-custom-logo-setting
branch
from
44e7f6d to
8756a39
Compare
nowgnuesLee
requested changes
Dec 22, 2025
Contributor
nowgnuesLee
left a comment
nowgnuesLee
left a comment
There was a problem hiding this comment.
please resolve the merge conflicts
ironAiken2
force-pushed
the
feat/FR-1688-custom-logo-setting
branch
from
8756a39 to
8304832
Compare
ironAiken2
force-pushed
the
feat/FR-1688-custom-logo-setting
branch
from
8304832 to
cf04c72
Compare
Merge activity
|
### resolve #4838 [FR-1688](https://lablup.atlassian.net/browse/FR-1688?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ) Add Logo Customization Feature to User Settings This PR adds a new logo customization feature to the user settings, allowing users to customize the WebUI logo for different modes: - Light mode logo - Dark mode logo - Collapsed sidebar logo in light mode - Collapsed sidebar logo in dark mode Users can either upload an image file (max 2MB) or specify a path to the logo. The uploaded logos are stored as base64 strings in local storage and can be previewed in real-time using the theme preview feature. The implementation includes: - A new `LogoPreviewer` component for handling logo uploads and path inputs - Integration with the existing theme customization system - Real-time preview capability for uploaded logos - Support for both light and dark modes in normal and collapsed sidebar states All translations for the new feature have been added to the i18n files in multiple languages. **Checklist:** - [x] Documentation - [ ] Minium required manager version - [x] Specific setting for review (User Settings > Logo section) - [x] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after [FR-1688]: https://lablup.atlassian.net/browse/FR-1688?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
graphite-app
bot
force-pushed
the
feat/FR-1688-custom-logo-setting
branch
from
cf04c72 to
b46ac74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #4838 FR-1688
Add Logo Customization Feature to User Settings
This PR adds a new logo customization feature to the user settings, allowing users to customize the WebUI logo for different modes:
Users can either upload an image file (max 2MB) or specify a path to the logo. The uploaded logos are stored as base64 strings in local storage and can be previewed in real-time using the theme preview feature.
The implementation includes:
LogoPreviewercomponent for handling logo uploads and path inputsAll translations for the new feature have been added to the i18n files in multiple languages.
Checklist: