Skip to content

Conversation

@yomybaby
Copy link
Member

@yomybaby yomybaby commented Dec 11, 2025

Resolves #4814 (FR-1788)

Add BooleanTag component and UI improvements

This PR adds a new BooleanTag component to display boolean values with appropriate styling, and makes several UI improvements:

  • Added a new BooleanTag component that renders boolean values as colored tags
  • Changed info icon colors from success to info color for better semantic meaning
  • Improved UserCredentialList with monospace formatting for access keys
  • Reorganized columns in UserCredentialList for better readability
  • Enhanced UserNodeList with additional fields and filtering options
  • Added UUID validation helper function
  • Updated translations for "Status Info" across all languages

@github-actions github-actions bot added area:ux UI / UX issue. area:i18n Localization size:L 100~500 LoC labels Dec 11, 2025
Copy link
Member Author

yomybaby commented Dec 11, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2025

Coverage report for ./packages/backend.ai-ui

St.
Category Percentage Covered / Total
🟡 Statements 60.7% 227/374
🔴 Branches 33.33% 104/312
🔴 Functions 48.31% 43/89
🟡 Lines 62.42% 206/330

Test suite run success

146 tests passing in 8 suites.

Report generated by 🧪jest coverage report action from a70f8f8

@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2025

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 4.23% 496/11736
🔴 Branches 3.65% 298/8159
🔴 Functions 2.54% 92/3619
🔴 Lines 4.2% 482/11478

Test suite run success

144 tests passing in 13 suites.

Report generated by 🧪jest coverage report action from a70f8f8

@yomybaby yomybaby force-pushed the feat/FR-1785-improve-admin-settings-accessibility branch from 655c7aa to 2bb0f34 Compare December 12, 2025 11:52
@yomybaby yomybaby force-pushed the feat/FR-1788-add-more-fields-user-list branch from 24e73b2 to da215a8 Compare December 12, 2025 11:52
Base automatically changed from feat/FR-1785-improve-admin-settings-accessibility to main December 12, 2025 11:55
@yomybaby yomybaby force-pushed the feat/FR-1788-add-more-fields-user-list branch from da215a8 to c9f84cc Compare December 19, 2025 10:06
@github-actions github-actions bot added size:XL 500~ LoC and removed size:L 100~500 LoC labels Dec 19, 2025
@yomybaby yomybaby force-pushed the feat/FR-1788-add-more-fields-user-list branch from c9f84cc to f8c5eb7 Compare December 19, 2025 10:09
@yomybaby yomybaby marked this pull request as ready for review December 19, 2025 10:09
Copilot AI review requested due to automatic review settings December 19, 2025 10:09
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds internationalization improvements and UI enhancements to the User list pages by introducing a new BooleanTag component and expanding data display capabilities.

Key changes:

  • Added a new reusable BooleanTag component for displaying boolean values with consistent styling
  • Enhanced User list pages with additional fields (container UID/GID, password change status, 2FA status, etc.)
  • Improved semantic meaning by changing info icon colors from success (green) to info (blue)
  • Added monospace formatting for access keys in credential lists for better readability
  • Added UUID validation helper function for filtering

Reviewed changes

Copilot reviewed 26 out of 27 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
resources/i18n/*.json Added translations for "StatusInfo", "CreatedAt", "ModifiedAt", and "Project" across all language files
packages/backend.ai-ui/src/components/BooleanTag.tsx New component for rendering boolean values as colored tags with fallback support
packages/backend.ai-ui/src/components/index.ts Exports the new BooleanTag component
react/src/helper/index.tsx Added UUID validation helper function
react/src/components/UserNodeList.tsx Major enhancement with new fields, filters, BooleanTag usage, and icon color updates
react/src/components/UserCredentialList.tsx Column reorganization, monospace access key display, and icon color updates
react/src/components/KeypairResourcePolicyList.tsx Updated info icon color from success to info

@yomybaby yomybaby force-pushed the feat/FR-1788-add-more-fields-user-list branch from f8c5eb7 to 9f7bd5d Compare December 22, 2025 07:38
@yomybaby yomybaby force-pushed the feat/FR-1788-add-more-fields-user-list branch 3 times, most recently from 8d8f0ae to e2c26aa Compare December 23, 2025 03:28
@yomybaby yomybaby requested a review from nowgnuesLee December 23, 2025 03:31
@yomybaby yomybaby requested a review from nowgnuesLee December 23, 2025 09:02
Copy link
Contributor

@nowgnuesLee nowgnuesLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yomybaby yomybaby force-pushed the feat/FR-1788-add-more-fields-user-list branch from e2c26aa to dcd45f1 Compare December 24, 2025 01:34
@yomybaby yomybaby force-pushed the feat/FR-1788-add-more-fields-user-list branch from dcd45f1 to eb24ea2 Compare December 24, 2025 02:57
@yomybaby yomybaby requested a review from ironAiken2 December 24, 2025 02:57
Copy link
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graphite-app
Copy link

graphite-app bot commented Dec 24, 2025

Merge activity

…allBack component (#4820)

Resolves #4814 ([FR-1788](https://lablup.atlassian.net/browse/FR-1788))

# Add BooleanTag component and UI improvements

This PR adds a new `BooleanTag` component to display boolean values with appropriate styling, and makes several UI improvements:

- Added a new `BooleanTag` component that renders boolean values as colored tags
- Changed info icon colors from success to info color for better semantic meaning
- Improved UserCredentialList with monospace formatting for access keys
- Reorganized columns in UserCredentialList for better readability
- Enhanced UserNodeList with additional fields and filtering options
- Added UUID validation helper function
- Updated translations for "Status Info" across all languages

[FR-1788]: https://lablup.atlassian.net/browse/FR-1788?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
@graphite-app graphite-app bot force-pushed the feat/FR-1788-add-more-fields-user-list branch from 562b663 to a70f8f8 Compare December 24, 2025 04:48
@graphite-app graphite-app bot merged commit a70f8f8 into main Dec 24, 2025
12 checks passed
@graphite-app graphite-app bot deleted the feat/FR-1788-add-more-fields-user-list branch December 24, 2025 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:i18n Localization area:ux UI / UX issue. size:XL 500~ LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more fields to User list page

4 participants