-
Notifications
You must be signed in to change notification settings - Fork 78
feat(FR-1788): add more fields to User list page with BooleanTagWithFallBack component #4820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 60.7% | 227/374 |
| 🔴 | Branches | 33.33% | 104/312 |
| 🔴 | Functions | 48.31% | 43/89 |
| 🟡 | Lines | 62.42% | 206/330 |
Test suite run success
146 tests passing in 8 suites.
Report generated by 🧪jest coverage report action from a70f8f8
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.23% | 496/11736 |
| 🔴 | Branches | 3.65% | 298/8159 |
| 🔴 | Functions | 2.54% | 92/3619 |
| 🔴 | Lines | 4.2% | 482/11478 |
Test suite run success
144 tests passing in 13 suites.
Report generated by 🧪jest coverage report action from a70f8f8
655c7aa to
2bb0f34
Compare
24e73b2 to
da215a8
Compare
da215a8 to
c9f84cc
Compare
c9f84cc to
f8c5eb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds internationalization improvements and UI enhancements to the User list pages by introducing a new BooleanTag component and expanding data display capabilities.
Key changes:
- Added a new reusable
BooleanTagcomponent for displaying boolean values with consistent styling - Enhanced User list pages with additional fields (container UID/GID, password change status, 2FA status, etc.)
- Improved semantic meaning by changing info icon colors from success (green) to info (blue)
- Added monospace formatting for access keys in credential lists for better readability
- Added UUID validation helper function for filtering
Reviewed changes
Copilot reviewed 26 out of 27 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
resources/i18n/*.json |
Added translations for "StatusInfo", "CreatedAt", "ModifiedAt", and "Project" across all language files |
packages/backend.ai-ui/src/components/BooleanTag.tsx |
New component for rendering boolean values as colored tags with fallback support |
packages/backend.ai-ui/src/components/index.ts |
Exports the new BooleanTag component |
react/src/helper/index.tsx |
Added UUID validation helper function |
react/src/components/UserNodeList.tsx |
Major enhancement with new fields, filters, BooleanTag usage, and icon color updates |
react/src/components/UserCredentialList.tsx |
Column reorganization, monospace access key display, and icon color updates |
react/src/components/KeypairResourcePolicyList.tsx |
Updated info icon color from success to info |
f8c5eb7 to
9f7bd5d
Compare
8d8f0ae to
e2c26aa
Compare
nowgnuesLee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e2c26aa to
dcd45f1
Compare
dcd45f1 to
eb24ea2
Compare
ironAiken2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
eb24ea2 to
562b663
Compare
Merge activity
|
…allBack component (#4820) Resolves #4814 ([FR-1788](https://lablup.atlassian.net/browse/FR-1788)) # Add BooleanTag component and UI improvements This PR adds a new `BooleanTag` component to display boolean values with appropriate styling, and makes several UI improvements: - Added a new `BooleanTag` component that renders boolean values as colored tags - Changed info icon colors from success to info color for better semantic meaning - Improved UserCredentialList with monospace formatting for access keys - Reorganized columns in UserCredentialList for better readability - Enhanced UserNodeList with additional fields and filtering options - Added UUID validation helper function - Updated translations for "Status Info" across all languages [FR-1788]: https://lablup.atlassian.net/browse/FR-1788?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
562b663 to
a70f8f8
Compare

Resolves #4814 (FR-1788)
Add BooleanTag component and UI improvements
This PR adds a new
BooleanTagcomponent to display boolean values with appropriate styling, and makes several UI improvements:BooleanTagcomponent that renders boolean values as colored tags