Add conditional installation option for Helm chart #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #20. This pull request introduces the ability to conditionally install the Helm chart in the
terraform-aws-eks-load-balancer-controller
. This feature is implemented through a new boolean variablehelm_enabled
, which allows users to decide whether the Helm chart should be installed during the Terraform apply phase.Motivation and Context
In some scenarios, users may need to manage IAM roles and policies separately from the installation of the Helm chart. The current implementation does not support conditional installation of the Helm chart, which can limit flexibility and control over the deployment process. By introducing this feature, users can have more granular control over their infrastructure components, which is particularly useful for compliance and security-focused environments.
How Has This Been Tested?
helm_enabled = true
: Ensures that the Helm chart is successfully installed.helm_enabled = false
: Ensures no Helm chart components are deployed and only IAM roles and policies are set up.Tests were conducted in both scenarios to ensure that the new variable correctly influences the deployment process and that existing functionalities are not affected by this change.
Checklist:
This enhancement provides additional flexibility and aligns with the philosophy of managing infrastructure as code, enabling more dynamic and configurable deployments.
Further comments
I welcome any feedback on this change and am open to discussing any further enhancements or modifications that might be necessary.
This format is suitable for creating a pull request on GitHub to merge the changes from your forked repository into the original terraform-aws-eks-load-balancer-controller project.
Type of change
fix
)feat
)refactor
)test
)style
)ci
)docs
)