Skip to content

Conversation

unitmatrix
Copy link
Contributor

@unitmatrix unitmatrix commented Jul 25, 2024

Description

Closes #20. This pull request introduces the ability to conditionally install the Helm chart in the terraform-aws-eks-load-balancer-controller. This feature is implemented through a new boolean variable helm_enabled, which allows users to decide whether the Helm chart should be installed during the Terraform apply phase.

Motivation and Context

In some scenarios, users may need to manage IAM roles and policies separately from the installation of the Helm chart. The current implementation does not support conditional installation of the Helm chart, which can limit flexibility and control over the deployment process. By introducing this feature, users can have more granular control over their infrastructure components, which is particularly useful for compliance and security-focused environments.

How Has This Been Tested?

  • Environment: Provide details about the environment in which the tests were run.
  • Test Configuration: Description of the test setup.
  • Test Cases:
    • helm_enabled = true: Ensures that the Helm chart is successfully installed.
    • helm_enabled = false: Ensures no Helm chart components are deployed and only IAM roles and policies are set up.

Tests were conducted in both scenarios to ensure that the new variable correctly influences the deployment process and that existing functionalities are not affected by this change.

Checklist:

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

This enhancement provides additional flexibility and aligns with the philosophy of managing infrastructure as code, enabling more dynamic and configurable deployments.

Further comments

I welcome any feedback on this change and am open to discussing any further enhancements or modifications that might be necessary.

This format is suitable for creating a pull request on GitHub to merge the changes from your forked repository into the original terraform-aws-eks-load-balancer-controller project.

Type of change

  • A bug fix (PR prefix fix)
  • A new feature (PR prefix feat)
  • A code change that neither fixes a bug nor adds a feature (PR prefix refactor)
  • Adding missing tests or correcting existing tests (PR prefix test)
  • Changes that do not affect the meaning of the code like white-spaces, formatting, missing semi-colons, etc. (PR prefix style)
  • Changes to our CI configuration files and scripts (PR prefix ci)
  • Documentation only changes (PR prefix docs)

@unitmatrix
Copy link
Contributor Author

Hi team,

I hope everyone is doing well. I wanted to follow up on this pull request submitted on Jul 25. Could someone please provide an update on the status of this PR? I'm looking forward to any further feedback or actions needed to move this forward.

Thank you for your time!

@jaygridley jaygridley self-assigned this Dec 5, 2024
@jaygridley jaygridley self-requested a review December 5, 2024 13:30
Copy link
Member

@jaygridley jaygridley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaygridley jaygridley merged commit 21f7af9 into lablabs:main Dec 5, 2024
@jaygridley jaygridley added this to the v2.0.0 milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Add Conditional Installation Option for Helm Chart
2 participants