topic/dictionary functions #1
Conversation
In many testcases it is desired to convert the output of a command into a dictionary. The function "split_output_to_dict" executes a command with a given command protocol and generates a dictionary from the output. Signed-off-by: Jonathan Goetzinger <j.goetzinger@eckelmann.de>
Signed-off-by: Jonathan Goetzinger <j.goetzinger@eckelmann.de>
Do not count delimiters to check if the line contains one or more delimiters. Signed-off-by: Jonathan Goetzinger <j.goetzinger@eckelmann.de>
There was a problem hiding this comment.
Change looks good, however I think the submodule dictionary_functions is quite long. Maybe labgridhelper.dict? Or reference it as a module for the command protocol, i.e. labgridhelper.command?
I think the helper function should not execute the command and leave that to the caller. This affords a more flexible use which does not rely on using the run_check call and allows use with run instead. We also only need to take a command_protocol output in this case.
Than it should also be renamed to split_command_output_to_dict.
| @@ -0,0 +1,23 @@ | |||
| def split_output_to_dict(command_protocoll, command, delimiter="=", strip_chars=""): | |||
There was a problem hiding this comment.
command_protocol with one l please. Other occurences in the file need to be fixed as well.
the function split_to_dict is no longer executing the command. Instead it takes the command output as an input argument. This leaves the decision to execute with run or with run_check to the caller. Signed-off-by: Jonathan Goetzinger <j.goetzinger@eckelmann.de>
|
Thanks for the feedback. I changed the function so that it no longer executes the command. Instead it takes the command output as an input argument. The module and function names are shorter now. |
|
Thanks! |
In many testcases it is desired to convert the output of a command into a dictionary. The function "split_output_to_dict" executes a command with a given command protocol and generates a dictionary from the output.