Avoid choosing the MapTileSource in app preferences. Let Mapnik by default. #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I checked this PR and indeed now the option to select the tile provider has been removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix issue #96, #125, #127
The options
CycleMapandMapQuestare not available any more for using them in the app.The only source available that woks in the same way is MAPNIK so we decided that, by the moment, the app will use by default the MAPNIK tile source. If this is the best for the app and users, we can let this change be permanent.
With this PR the map tile source can not be changed. This is for avoiding exceptions and because MAPNIK will be used anyway if the selected source does not work correctly (throws an exception) and this will happen if
MapQuestorCycleMapare chosen.In conclusion the functionality of choosing the map tile source was useless right now.