Skip to content

fail plex jobs based on bacalhau status #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 20, 2023
Merged

fail plex jobs based on bacalhau status #529

merged 3 commits into from
Jul 20, 2023

Conversation

thetechnocrat-dev
Copy link
Contributor

@thetechnocrat-dev thetechnocrat-dev commented Jul 20, 2023 •
edited
Loading

This code now Gets the Bacalhau job and checks the status before attempting to get the job results. If the Bacalhau job is in a cancelled or errored state, it will immediately return the error. Apparently, the Bacalhau GetJobResults was not raising an error in these cases.

Below is where I started a job and then used bacalhau cancel <job_id> to test

Starting to process IO entry 0 
Job running...
Bacalhau job id: 143dabba-fc73-4f15-b63e-68c98f76138a 
Error processing IO entry 0 
error getting Bacalhau job results: bacalhau cancelled job
Finished processing, results written to /Users/mcmenemy/code/plex/jobs/b855aee6-4b28-4f07-8e9b-40b7d7cb9cd3/io.json
Completed IO JSON CID: QmSPf6aGZFVNtFaxSH66UKXGGmCY5LZybWx8y2UkjJ2yL7

@thetechnocrat-dev thetechnocrat-dev linked an issue Jul 20, 2023 that may be closed by this pull request
plex not picking up all bacalhau errors #528
Closed
@vercel
Copy link

vercel bot commented Jul 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2023 7:36pm

@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci July 20, 2023 18:03 — with GitHub Actions Inactive
@thetechnocrat-dev thetechnocrat-dev temporarily deployed to ci July 20, 2023 18:04 — with GitHub Actions Inactive
@acashmoney acashmoney temporarily deployed to ci July 20, 2023 19:36 — with GitHub Actions Inactive
acashmoney
acashmoney approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@acashmoney acashmoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 🟢 🟣

@thetechnocrat-dev thetechnocrat-dev merged commit 947f85e into main Jul 20, 2023
@thetechnocrat-dev thetechnocrat-dev deleted the 528-plex-not-picking-up-all-bacalhau-errors branch July 20, 2023 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acashmoney acashmoney acashmoney approved these changes

@alabdao alabdao Awaiting requested review from alabdao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plex not picking up all bacalhau errors
2 participants
@thetechnocrat-dev @acashmoney