Skip to content

fix: update content type display_field to be optional and handle empty values #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

demeyerthom
Copy link
Member

This pull request addresses a bug where setting contenttype.display_field to empty caused issues during the apply phase. The changes ensure that display_field is now optional across the codebase and properly handles empty values. The key updates include modifications to the SDK models, resource logic, and documentation.

Bug Fixes and Functional Updates:

SDK Model Adjustments:

  • internal/sdk/main.gen.go: Changed the DisplayField field in ContentType, ContentTypeCreate, and ContentTypeUpdate structs from string to *string to make it optional. [1] [2] [3]

OpenAPI Specification Updates:

  • openapi.yaml: Removed displayField from the list of required fields for ContentType, ContentTypeCreate, and ContentTypeUpdate components. [1] [2] [3]

Documentation Updates:

@demeyerthom demeyerthom requested a review from a team as a code owner August 1, 2025 13:39
@demeyerthom demeyerthom force-pushed the 96-cant-do-terraform-plan-when-a-content-type-does-not-contain-display_field branch from 06fff23 to ab18ad4 Compare August 1, 2025 13:51
@demeyerthom demeyerthom merged commit f5d51cf into main Aug 1, 2025
2 checks passed
@demeyerthom demeyerthom deleted the 96-cant-do-terraform-plan-when-a-content-type-does-not-contain-display_field branch August 1, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't do terraform plan when a content type does not contain display_field
1 participant