fix: update content type display_field to be optional and handle empty values #98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a bug where setting
contenttype.display_field
to empty caused issues during the apply phase. The changes ensure thatdisplay_field
is now optional across the codebase and properly handles empty values. The key updates include modifications to the SDK models, resource logic, and documentation.Bug Fixes and Functional Updates:
.changes/unreleased/Fixed-20250801-153756.yaml
: Added a changelog entry to document the fix for thecontenttype.display_field
issue.internal/resources/contenttype/model.go
: Updated theCreate
,Update
,Import
, andEqual
methods to useValueStringPointer()
forDisplayField
, ensuring proper handling ofnil
values. [1] [2] [3] [4]SDK Model Adjustments:
internal/sdk/main.gen.go
: Changed theDisplayField
field inContentType
,ContentTypeCreate
, andContentTypeUpdate
structs fromstring
to*string
to make it optional. [1] [2] [3]OpenAPI Specification Updates:
openapi.yaml
: RemoveddisplayField
from the list of required fields forContentType
,ContentTypeCreate
, andContentTypeUpdate
components. [1] [2] [3]Documentation Updates:
docs/resources/contenttype.md
: Moveddisplay_field
from the "Required" to the "Optional" section to reflect its new status. [1] [2]