fix: interpretation of slice nil pointer instead of empty slice in validation draft #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demeyerthom
changed the title
demeyerthom
deleted the
73-disable-all-nodes-types-for-richtext-validation-breaks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a bug in content type validation and enhances the robustness of the
Validationstruct by refining its handling of nil slices. Additionally, it introduces comprehensive unit tests to ensure correctness and prevent regressions.Bug Fixes:
.changes/unreleased/Fixed-20250613-100705.yaml: Added a changelog entry documenting the fix for content type validation misinterpreting nil slices as empty slices.Code Improvements:
internal/resources/contenttype/model.go: Updated theDraftmethod in theValidationstruct to check fornilslices instead of usinglen()checks, ensuring proper handling of uninitialized slices.Testing Enhancements:
internal/resources/contenttype/model_test.go: Added unit tests for theDraftmethod to verify behavior for unsupported validations, unique validations, andEnabledNodeTypesvalidations, ensuring comprehensive coverage.