-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GraphQL interface #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty clear to me 👍
01ff0c7
to
7c97af1
Compare
Codecov Report
@@ Coverage Diff @@
## master #49 +/- ##
==========================================
+ Coverage 10.57% 10.63% +0.05%
==========================================
Files 61 62 +1
Lines 13160 13227 +67
==========================================
+ Hits 1392 1407 +15
- Misses 11612 11661 +49
- Partials 156 159 +3
Continue to review full report at Codecov.
|
ef6c7eb
to
e68df95
Compare
This PR refactors the existing client request/response processing into two separate functions since we want to re-use the request logic but handle the response for graphql differently.
e68df95
to
fb8e54c
Compare
Need to add unittest later (want to get a poc working for custom apps first) |
Note that this is a work in progress (missing unittest)
Example usage:
See also https://github.com/labd/terraform-provider-commercetools/pull/109/files