Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed while condition in encode_matches_count so it doesn't get stuck… #7

Merged
merged 1 commit into from
May 31, 2018

Conversation

dalton-tulou
Copy link
Contributor

… when count is negative

I found that this could happen due to the while (count--) at line 687.

@lab313ru
Copy link
Owner

Do you have any example file for this situation?
As I remember, I've fixed this case already.

@lab313ru
Copy link
Owner

And... your fix is not corresponding to your description.

@dalton-tulou
Copy link
Contributor Author

I’m not 100% sure about the cause, but method 2 packing definitely fails for most of my files. I’m on cell phone now so I don’t have access to the files. But I will upload later.

The while at 687 exits when count==0, and then subtracts 1 from count, leaving count=-1.

The code loops back to the while at 654. I believe that line doesn’t work as intended when count<0.

@lab313ru
Copy link
Owner

If you're using some of 'Release' versions then it will contain a bug, because I didn't upload a new versions yet.
Have you tried to compile my code?

@dalton-tulou
Copy link
Contributor Author

I compiled from source using visual studio

@lab313ru lab313ru merged commit b3457af into lab313ru:master May 31, 2018
@lab313ru
Copy link
Owner

Confirmed.

@dalton-tulou
Copy link
Contributor Author

Thank you! I have great respect for all the work which must have been invested in reverse-engineering RNC.

@lab313ru
Copy link
Owner

Thank you!:)

@lab313ru
Copy link
Owner

lab313ru commented May 31, 2018

Also, you may look at my other reversed project: https://github.com/lab313ru/AmigaImploder

It is Amiga's Imploder - another popular cruncher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants