Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention highlights render w/ gray highlight #176

Closed
orcinus opened this issue Jul 11, 2018 · 0 comments
Closed

Mention highlights render w/ gray highlight #176

orcinus opened this issue Jul 11, 2018 · 0 comments
Labels
styling

Comments

@orcinus
Copy link

orcinus commented Jul 11, 2018 •
edited
Loading

Digging through some old issues, it looks like the mention highlights used to remain their default yellow (with a custom dark text color to preserve contrast).

It looks like now the mentions are gray, which makes them not stand out at all on a dark(er) gray background. In fact, you need to read every message to figure out where you were actually mentioned, rendering mention highlights wholly useless.

Not sure if that was an intentional change or not, but it probably needs tweaking either way.
Zoooook pushed a commit to Zoooook/slack-night-mode that referenced this issue Jul 3, 2020
@mastermel
restore yellow background of highligh-mentions
ddfde2c 
Fixes laCour#176

Test Plan:
- Add a highlight word that is someone's slack alias
- Mention that user in a channel
- Verify that the mention is styled with a light-yellow background, and
  clearly stands out from other user mentions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
styling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@orcinus @mastermel