Add ability to enable the auto-filters on a worksheet #68
Conversation
This will result in the sheet having dropdown filters in the first header row.
kevmo314
left a comment
kevmo314
left a comment
There was a problem hiding this comment.
Thanks for the change!
| def get_auto_filter_xml_string(self): | ||
| if self.auto_filter: | ||
| return '<autoFilter ref="{}"/>'.format( | ||
| Range.Range((1, 1), (self.num_rows, self.num_columns), self) |
There was a problem hiding this comment.
Is <autoFilter> with a non-encompassing range valid? It seems like it may be better to have the auto_filter property take a Range or boolean type, with the latter setting it as the entire worksheet. My guess is a @property and @auto_filter.setter will end up being cleaner.
There was a problem hiding this comment.
To be honest I do not know the precise specification of what is allowable, I simply got this from reversing what Excel did when toggling on the feature. I'll investigate when I get a chance and get back to you.
There was a problem hiding this comment.
Ok so I took a look at the open office spec regarding <autoFilter>, turns out it can take on quite a few values, including have child elements to support more complex filtering.
Your use case is probably the most common though, and I'm assuming you'd like to have it in the lib, so we can merge the PR as-is and we'll take a look at adding support for all the other stuff in a future change. :)
2 participants
This will result in the sheet having dropdown filters in the first header row.
Let me know if you prefer to use a different syntax or API to enable this.