Add ability to save workbook to an open file handle #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be nice to be able to pass an open filehandle to the workbook save, instead of solely allowing a filename. This can be useful for example to save the workbook somewhere that cannot be referenced by a filename, such as a `BytesIO` object in memory.
Collaborator
|
Change seems reasonable. Please take a look/fix the failing py2.7 test and we can merge this in. Thanks for the contribution! |
It is not as clean to check for a file-like object in python 2, so invert the if statements and check for string instead.
Contributor
Author
|
Thanks @kevmo314. Apologies for not testing in python 2. I've inverted the check now since its not as clean to check for file-like objects in 2. Let me know if you would like me to squash the commits. |
Collaborator
|
Looks good, no need to squash, thanks for the change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
It would be nice to be able to pass an open filehandle to the workbook save, instead of solely allowing a filename. This can be useful for example to save the workbook somewhere that cannot be referenced by a filename, such as a
BytesIOobject in memory.My apologies in advance if this has been discussed or ruled out before, I am happy to discuss or make changes if you like. Thank you for sharing this library, it suits a use-case I have very well and is much faster than the other libraries I have benchmarked.