Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to override namespace for serviceMonitor, and use new value for… #57

Merged
merged 1 commit into from
Aug 20, 2021

Conversation

Issif
Copy link

@Issif Issif commented Aug 20, 2021

This PR introduces:

  • allow to override the namespace for the serviceMonitor
  • allow to override the namespace for configMaps for grafana dashboard

… configMap for grafana dashboards

Signed-off-by: Thomas Labarussias <thomas.labarussias@qonto.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1149977419

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.492%

Totals Coverage Status
Change from base Build 1113984382: 0.0%
Covered Lines: 1503
Relevant Lines: 1625

💛 - Coveralls

@fjogeleit fjogeleit merged commit f29e868 into kyverno:main Aug 20, 2021
@fjogeleit
Copy link
Member

Thank you and welcome on board

@Issif
Copy link
Author

Issif commented Aug 20, 2021

I forgot to override the helm chart version, is that an issue?

@fjogeleit
Copy link
Member

No, I was also working on the helm chart and changed it together with my changes

Your PR is released with https://github.com/kyverno/policy-reporter/releases/tag/policy-reporter-1.8.7

fjogeleit pushed a commit that referenced this pull request Aug 20, 2021
Merge pull request #57 from Issif/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants