Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/issue_377] Allow additional env variables to be added #378

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

kbcbals
Copy link
Contributor

@kbcbals kbcbals commented Dec 5, 2023

Added the support for adding additional env variables to the policy reporter deployment.
It's needed as currently there is no way to add additional env variables to the main policy-reporter chart.

Signed-off-by: Balamurugan Balasubramanian <balamurugan.balasubramanian@williamhill.com>
@fjogeleit
Copy link
Member

thanks for your contribution, looks good in general but should also be added in the UI andplugin subchart.

@coveralls
Copy link

coveralls commented Dec 5, 2023

Pull Request Test Coverage Report for Build 7114406698

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.022%

Totals Coverage Status
Change from base Build 7044141437: 0.0%
Covered Lines: 4533
Relevant Lines: 4926

💛 - Coveralls

…nded to the subcharts - ui and kyverno plugin and bumped the chart version

Signed-off-by: Balamurugan Balasubramanian <balamurugan.balasubramanian@williamhill.com>
@kbcbals
Copy link
Contributor Author

kbcbals commented Dec 6, 2023

@fjogeleit
Thanks for reviewing this PR. Please can i request a re-review as i have updated it with the changes as per the comments.

@fjogeleit
Copy link
Member

yes, looks good. The version failure is fine. I bump all version when I prepare the complete release.

@fjogeleit fjogeleit merged commit e9719c8 into kyverno:main Dec 6, 2023
3 checks passed
@kbcbals
Copy link
Contributor Author

kbcbals commented Dec 6, 2023

@fjogeleit
Cheers. Thanks for letting me know. Do you have a prospective date for the new version release.
We are eager to check this bit.

@fjogeleit
Copy link
Member

Theres at least one open issue I want to investigate beforehand. So maybe end of the week / beginning next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants