Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic auth for API and Metrics #343

Merged
merged 6 commits into from
Sep 10, 2023
Merged

basic auth for API and Metrics #343

merged 6 commits into from
Sep 10, 2023

Conversation

fjogeleit
Copy link
Member

@fjogeleit fjogeleit commented Sep 6, 2023

BasicAuthentication for APIs and Metrics endpoints

health- and readycheck API are excluded

  • username and password are configured as global values in Helm
  • applied on APIs and metrics
  • if monitoring is enabled it will also create a secret with the credentials in the ServiceMonitor namespace end applied to the endpoint configuration
  • authentication will be applied to core app and kyverno plugin, if enabled
  • UI will be configured to do authenticated calls

Signed-off-by: Frank Jogeleit <frank.jogeleit@web.de>
@fjogeleit fjogeleit linked an issue Sep 6, 2023 that may be closed by this pull request
Signed-off-by: Frank Jogeleit <frank.jogeleit@web.de>
Signed-off-by: Frank Jogeleit <frank.jogeleit@web.de>
@github-actions
Copy link

github-actions bot commented Sep 9, 2023

Pull Request Test Coverage Report for Build 6130903114

  • 41 of 86 (47.67%) changed or added relevant lines in 3 files are covered.
  • 12 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-1.1%) to 91.066%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/api/server.go 36 41 87.8%
pkg/config/resolver.go 5 22 22.73%
pkg/api/basic_auth.go 0 23 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/api/server.go 12 75.96%
Totals Coverage Status
Change from base Build 6083235733: -1.1%
Covered Lines: 4475
Relevant Lines: 4914

💛 - Coveralls

Signed-off-by: Frank Jogeleit <frank.jogeleit@web.de>
Signed-off-by: Frank Jogeleit <frank.jogeleit@web.de>
Signed-off-by: Frank Jogeleit <frank.jogeleit@web.de>
@fjogeleit fjogeleit merged commit ac83fac into main Sep 10, 2023
3 checks passed
@fjogeleit fjogeleit deleted the basic-auth branch September 10, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CORE] Auth for policy-reporter API
2 participants