Conversation
Signed-off-by: Jim Bugwadia <jim@nirmata.com>
JimBugwadia
requested review from
aerosouund,
eddycharly,
lucchmielowski and
realshuting
|
|
||
| - `conformance.yaml`: Remove `prepare-images` job, download artifacts from `build-images` workflow | ||
| - `load-testing.yml`: Remove `prepare-images` job, download artifacts from `build-images` workflow | ||
| - `images-build.yaml`: Can be deprecated or refactored to use the centralized workflow |
There was a problem hiding this comment.
load testing was recently removed from pipelines that run on anything non code related
on:
release:
types: [published]
pull_request:
branches:
- "main"
- "release*"
paths:
- "cmd/**"
- "pkg/**"And it was never a required workflow for merging. given this, images are already being built only once in conformance.yaml. also, if workflows are running in parallel (load testing and conformance) and each of them builds the image then the net wait time is that of a single image build. Is there any other way you see this can enhance our posture apart from build time ?
| **Go Module Cache:** | ||
|
|
||
| - Cache `${{ env.GOMODCACHE }}` and `${{ env.GOCACHE }}` in `setup-build-env` action | ||
| - Key: `go-mod-${{ runner.os }}-${{ hashFiles('**/go.sum') }}` |
There was a problem hiding this comment.
this could be nice for accelerating the build of images in case each controller container redownloads all go mods during its build
| run: npm test -- --shard=1/2 # Example of parallelizing | ||
| ``` | ||
|
|
||
| 2. The `Slow CI Workflow (slow-ci.yml)`. This workflow triggers only after code is successfully merged into the main branch. This is where you run heavy end-to-end (E2E) tests, performance benchmarks, or complex integration suites. |
There was a problem hiding this comment.
This is in my opinion be the highest return activity in the list. I would add that removing e2e tests (entirely) from pre-merge checks is too risky at this point. but the policy library ones indeed can be taken away. we can revisit this after we have completed the exploration of testing tools to see if we are in shape to reduce reliance on e2e tests
2 participants
No description provided.