Add KDP review/acceptance procedure + template#12
Merged
sambhav merged 1 commit intokyverno:mainfrom Apr 19, 2022
Merged
Conversation
Signed-off-by: Sambhav Kothari <skothari44@bloomberg.net>
realshuting
approved these changes
Apr 13, 2022
prateekpandey14
approved these changes
Apr 14, 2022
Contributor
|
This closes #7, correct? If so, please link. |
chipzoller
approved these changes
Apr 14, 2022
Contributor
chipzoller
left a comment
chipzoller
left a comment
There was a problem hiding this comment.
Please link to issue if addressed by this PR.
shubham4443
pushed a commit
to shubham4443/KDP
that referenced
this pull request
Jun 1, 2022
Signed-off-by: Sambhav Kothari <skothari44@bloomberg.net> Signed-off-by: shubham4443 <shubham4443@gmail.com>
chipzoller
pushed a commit
that referenced
this pull request
Jun 2, 2022
* Add extend CLI for generate policies proposal Signed-off-by: Shubham Nazare <shubham4443@gmail.com> Signed-off-by: shubham4443 <shubham4443@gmail.com> * Fix some grammar mistakes Signed-off-by: Shubham Nazare <shubham4443@gmail.com> Signed-off-by: shubham4443 <shubham4443@gmail.com> * Fix grammar and add API Design Changes Signed-off-by: Shubham Nazare <shubham4443@gmail.com> Signed-off-by: shubham4443 <shubham4443@gmail.com> * Change cloneResource to cloneSourceResource Signed-off-by: Shubham Nazare <shubham4443@gmail.com> Signed-off-by: shubham4443 <shubham4443@gmail.com> * Fix indentation Signed-off-by: Shubham Nazare <shubham4443@gmail.com> Signed-off-by: shubham4443 <shubham4443@gmail.com> * Add details for namespaced policy Signed-off-by: Shubham Nazare <shubham4443@gmail.com> Signed-off-by: shubham4443 <shubham4443@gmail.com> * Fix typo mistakes Signed-off-by: shubham4443 <shubham4443@gmail.com> * correcting hyperlinks Signed-off-by: Naman Lakhwani <namanlakhwani@gmail.com> Signed-off-by: shubham4443 <shubham4443@gmail.com> * update digest tags Signed-off-by: Jim Bugwadia <jim@nirmata.com> Signed-off-by: shubham4443 <shubham4443@gmail.com> * add table Signed-off-by: Jim Bugwadia <jim@nirmata.com> Signed-off-by: shubham4443 <shubham4443@gmail.com> * fix link Signed-off-by: Jim Bugwadia <jim@nirmata.com> Signed-off-by: shubham4443 <shubham4443@gmail.com> * Add KDP review/acceptance procedure + template (#12) Signed-off-by: Sambhav Kothari <skothari44@bloomberg.net> Signed-off-by: shubham4443 <shubham4443@gmail.com> * Rename origin to target Signed-off-by: shubham4443 <shubham4443@gmail.com> Co-authored-by: Naman Lakhwani <namanlakhwani@gmail.com> Co-authored-by: Jim Bugwadia <jim@nirmata.com> Co-authored-by: Sambhav Kothari <sambhavs.email@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an appropriate template and review process for KDPs.
Open for review/discussion around the template and voting process.
Fixes #7