Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ditch Cram #178

Merged
merged 17 commits into from
Dec 8, 2022
Merged

Ditch Cram #178

merged 17 commits into from
Dec 8, 2022

Conversation

arobrien
Copy link
Contributor

@arobrien arobrien commented Dec 5, 2022

Shift remaining tests from Cram to pytest.

Makes heavy use of the pytester fixture, especially pytester.run() and result.stdout.fnmatch_lines([...])

Minor changes to test_utils.py to get rid of pytest warnings.

Fixes #38
Closes #154
Closes #165

@kynan kynan added this to the 0.7.0 milestone Dec 6, 2022
@kynan kynan self-requested a review December 6, 2022 22:04
Copy link
Owner

@kynan kynan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for doing this! The tests are a little less readable, but we get a lot more flexibility at that price. And running on Windows of course, so it's worth it 👍🏽

@kynan kynan merged commit cb47322 into kynan:master Dec 8, 2022
@kynan kynan modified the milestones: 0.7.0, 0.6.2 Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace cram with prysk Evaluate docshtest instead of cram Fix Windows tests
2 participants