Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add option to keep output style #177

Merged
merged 1 commit into from
Dec 9, 2022
Merged

feat: add option to keep output style #177

merged 1 commit into from
Dec 9, 2022

Conversation

davidxia
Copy link
Contributor

with nbstripout --keep-metadata-keys or git config key filter.nbstripout.keepmetadatakeys.

closes #78

@davidxia davidxia marked this pull request as ready for review November 25, 2022 21:32
@davidxia davidxia mentioned this pull request Nov 29, 2022
Closed
davidxia
davidxia commented Nov 29, 2022
View reviewed changes
Copy link
Contributor Author

@davidxia davidxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a maintainer to approve running the tests.

README.rst Show resolved Hide resolved
kynan
kynan requested changes Nov 29, 2022
View reviewed changes
Copy link
Owner

@kynan kynan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this mostly LGTM. Tests seem to be failing though, could you please fix?

README.rst Outdated Show resolved Hide resolved
README.rst Show resolved Hide resolved
@davidxia
Copy link
Contributor Author

davidxia commented Dec 1, 2022

Thanks, this mostly LGTM. Tests seem to be failing though, could you please fix?

Updated. Looks like I need to be approved each time to run the tests.

@kynan
Copy link
Owner

kynan commented Dec 1, 2022

Tests still failing unfortunately :(

@davidxia
Copy link
Contributor Author

davidxia commented Dec 4, 2022

Sorry, fixed and made sure it passes for me locally.

@davidxia davidxia requested a review from kynan December 5, 2022 16:48
kynan
kynan approved these changes Dec 6, 2022
View reviewed changes
nbstripout/_nbstripout.py Outdated Show resolved Hide resolved
@kynan
Copy link
Owner

kynan commented Dec 6, 2022

Ugh, test failure is now entirely unrelated to your change, caused by actions/runner-images#6399

@kynan
Copy link
Owner

kynan commented Dec 6, 2022

"Fixed" in 4ff5477 by dropping 3.6 and adding 3.11 instead. Guess we have to go with the times...

Can you rebase this PR?

@davidxia
feat: add option to keep output style
4300c75 
with `nbstripout --keep-metadata-keys` or git config key
`filter.nbstripout.keepmetadatakeys`.

closes kynan#78
davidxia
davidxia commented Dec 8, 2022
View reviewed changes
Copy link
Contributor Author

@davidxia davidxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebased

nbstripout/_nbstripout.py Outdated Show resolved Hide resolved
@kynan kynan self-assigned this Dec 9, 2022
@kynan kynan added this to the 0.7.0 milestone Dec 9, 2022
@kynan kynan merged commit 1185a8d into kynan:master Dec 9, 2022
@kynan
Copy link
Owner

kynan commented Dec 9, 2022

Thanks for your contribution!

@davidxia davidxia deleted the feat1 branch December 9, 2022 22:48
@davidxia
Copy link
Contributor Author

davidxia commented Dec 9, 2022

thank you!

@kynan kynan modified the milestones: 0.7.0, 0.6.2 Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kynan kynan kynan approved these changes

Assignees

@kynan kynan

Labels
resolution:merged type:enhancement
Projects
None yet
Milestone
0.6.2
Development

Successfully merging this pull request may close these issues.

Option to keep output style
2 participants
@davidxia @kynan