Add support for stripping init cells #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kynan
requested changes
Sep 19, 2021
|
For some reason CI hasn't run on this PR. Investigating what's happened there. |
|
My bad, I hadn't configured GitHub Actions to run on a PR. I had to push a dummy commit to your branch to trigger CI. |
kynan
requested changes
Sep 19, 2021
|
Thank you. I have fixed the tests, and added a new one for the new case. |
kynan
approved these changes
Sep 20, 2021
kynan
added
resolution:merged
and removed
state:waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #156 :
This PR adds a flag:
--strip-init-cellswhich alters the current behavior to also remove outputs from init cells.Reason:
I have a whole bunch of notebooks which have the
init_cell: truemetadata. This generates a nice default set of UI widgets as soon as the notebook is loaded. However, since this is generated automatically, I don't want all the widget output checked into my source repo. Right now, every time a user commits a change to the notebook, we have huge amounts of cell output from the init_cell cells.