Golint is deprecated

[halamix2]

Description

Golint was deprecated: golang/go#38968
A golint is run by before-commit.sh script. This script is starting multiple tests/linters apart from golint.
A list of features provided by script should be used as a list of prowjobs to create.
Each prowjob should implement one feature from the list.
At the end all features must be provided by some standalone prowjob with dedicated tool.

• Check if we need to use golint or other tools we have cover all of its use cases. Check if we need to use golint or other tools we have cover all of its use cases. #5746
• check if we can replace golint with https://github.com/mgechev/revive
• Golangci-lint linter only files changeed in PR. Golangci-lint linter only files changeed in PR. #5745
• Define configuration for each repository.
• Define prowjobs for each repostiory.
  Reasons

• One of the PRs is stuck on the golint tool dependencies: gomod(deps): bump go.uber.org/zap from 1.19.0 to 1.21.0 #4905

Acceptance Criteria

• Replacement can work with files changed in PR only.
• Replacement can work against whole repository.
• Prowjob running a linter should not have dependency to test-infra.
• Replacement should allow for different configuration per repository.
• Prowjobs running a replacment should be stored in test-infra repository.
• Replacement must cover all features already provided by before-commit.sh script.

Attachments

/kind deprecation

[Ressetkk]

Let's try to deprecate the entire before-commit.sh script. We can use presubmits that will run on every PR that touches go code.

[Ressetkk]

Maybe it'd be good to introduce the separate job that runs listing against entire codebase with using https://github.com/golangci/golangci-lint.

[Ressetkk]

Static check are all over the place. We use at least 3 different binaries for static checks and different approaches.

• We have before-commit.sh that directly runs linter across go codebase as a step
• We have a makefile check that does the same
• There is also https://github.com/kyma-project/kyma/tree/main/hack directory maintained only by @clebs which contains the static checks shell script

We really need to look at some unified approach for static checks for all go code. Let's validate if golangci-lint running as a separate job would be enough. That job would run only when the go code is replaced. We can maintain it and configure autobumper so bumping is easy.

Let's work on that ASAP since it's getting out of hand.

[ghost]

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.

[kasiakepka]

Related issue: kyma-project/kyma#11053

[github-actions]

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.

[kyma-bot]

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

• After 60d of inactivity, lifecycle/stale is applied
• After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

[halamix2]

/remove-lifecycle stale

[kyma-bot]

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

• After 60d of inactivity, lifecycle/stale is applied
• After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

[kyma-bot]

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

• After 60d of inactivity, lifecycle/stale is applied
• After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

[kyma-bot]

@kyma-bot: Closing this issue.

In response to this:

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

• After 60d of inactivity, lifecycle/stale is applied
• After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

• Reopen this issue or PR with /reopen
• Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kyma-bot]

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

• After 60d of inactivity, lifecycle/stale is applied
• After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

[Ressetkk]

I believe we already agreed to use golangci-lint for all go-related codebase static checks. No need to keep this issue for this long.
/close

[kyma-bot]

@Ressetkk: Closing this issue.

In response to this:

I believe we already agreed to use golangci-lint for all go-related codebase static checks. No need to keep this issue for this long.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.