Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade event bus dependencies to kubernetes 1.12.6 #5356

Conversation

montaro
Copy link
Contributor

@montaro montaro commented Aug 19, 2019

See also #5168

@montaro montaro requested a review from a user August 19, 2019 15:54
@montaro montaro self-assigned this Aug 19, 2019
@montaro montaro added the area/eventing Issues or PRs related to eventing label Aug 19, 2019
@montaro
Copy link
Contributor Author

montaro commented Aug 19, 2019

/retest

1 similar comment
@montaro
Copy link
Contributor Author

montaro commented Aug 20, 2019

/retest

@montaro
Copy link
Contributor Author

montaro commented Aug 20, 2019

/test pre-master-kyma-components-event-bus

@montaro
Copy link
Contributor Author

montaro commented Aug 20, 2019

/retest

1 similar comment
@anishj0shi
Copy link
Member

/retest

@anishj0shi anishj0shi self-requested a review August 20, 2019 13:12
Copy link
Member

@anishj0shi anishj0shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@montaro
Copy link
Contributor Author

montaro commented Aug 21, 2019

/retest

@montaro montaro force-pushed the upgrade-Event-Bus-dependencies-to-Kubernetes-1.15 branch 2 times, most recently from 25c5ff1 to da3cc35 Compare August 21, 2019 10:54
@@ -1,4 +1,4 @@
apiVersion: extensions/v1beta1
Copy link
Contributor

@sayanh sayanh Aug 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be, we can move these changes(related to charts) to another PR(will be created anyway) which will have the bumped image of subscription-controller.

kubernetes-1.12.6

Update Gopkg.lock

fix imports

Delete my-kyma.yaml

Update reconcile_test.go

Update Gopkg.lock

Update publish.go

Update Gopkg.toml

Update Gopkg.lock

Update Gopkg.lock

Update before-commit.sh
@montaro montaro requested a review from a-thaler as a code owner August 21, 2019 18:13
@montaro montaro force-pushed the upgrade-Event-Bus-dependencies-to-Kubernetes-1.15 branch from 2d03242 to e8b7b99 Compare August 21, 2019 18:34
@montaro montaro merged commit ca911a6 into kyma-project:master Aug 21, 2019
@lilitgh lilitgh added this to the Sprint_SkydivingTunas_2 milestone Aug 23, 2019
sayanh added a commit to sayanh/kyma that referenced this pull request Sep 3, 2019
sayanh added a commit to sayanh/kyma that referenced this pull request Sep 3, 2019
sayanh added a commit that referenced this pull request Sep 4, 2019
* Revert "uncomment event-bus subscription-controller tests (#5418)"

This reverts commit f153bb3.

* Revert "updated k8s libs to 1.15.2 (#5356)"

This reverts commit ca911a6.
suleymanakbas91 pushed a commit to suleymanakbas91/kyma that referenced this pull request Sep 4, 2019
…5536)

* Revert "uncomment event-bus subscription-controller tests (kyma-project#5418)"

This reverts commit f153bb3.

* Revert "updated k8s libs to 1.15.2 (kyma-project#5356)"

This reverts commit ca911a6.
suleymanakbas91 pushed a commit that referenced this pull request Sep 4, 2019
* Revert "uncomment event-bus subscription-controller tests (#5418)"

This reverts commit f153bb3.

* Revert "updated k8s libs to 1.15.2 (#5356)"

This reverts commit ca911a6.
@montaro montaro deleted the upgrade-Event-Bus-dependencies-to-Kubernetes-1.15 branch December 20, 2019 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eventing Issues or PRs related to eventing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants