Skip to content

fix invalid module links #18763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix invalid module links #18763

merged 1 commit into from
Dec 11, 2024

Conversation

sleungcy
Copy link
Contributor

Description

Changes proposed in this pull request:

  • found invalid links in the doc

@sleungcy sleungcy requested a review from a team as a code owner November 28, 2024 23:02
@netlify Netlify
Copy link

netlify bot commented Nov 28, 2024

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 4d2017d

@CLAassistant
Copy link

CLAassistant commented Nov 28, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@kyma-bot
Copy link
Contributor

Hi @sleungcy. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 28, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 28, 2024 •
edited
Loading

✅ Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 4d2017d
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/6748f67fe2d9ba00082f998e
😎 Deploy Preview https://deploy-preview-18763--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NHingerl NHingerl self-assigned this Dec 2, 2024
@NHingerl NHingerl self-requested a review December 2, 2024 08:44
friedrichwilken
friedrichwilken approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@friedrichwilken friedrichwilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks right: https://github.com/kyma-project/nats-manager/releases

@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 11, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Dec 11, 2024
@kyma-bot kyma-bot merged commit e21df8e into kyma-project:main Dec 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@friedrichwilken friedrichwilken friedrichwilken approved these changes

@NHingerl NHingerl NHingerl approved these changes

Assignees

@friedrichwilken friedrichwilken

@NHingerl NHingerl

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sleungcy @CLAassistant @kyma-bot @friedrichwilken @NHingerl