fix docsify-tabs regex #18266
Merged
fix docsify-tabs regex #18266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for kyma-project pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for kyma-project-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kyma-bot
added
the
size/S
NHingerl
approved these changes
Oct 5, 2023
a-thaler
approved these changes
Oct 5, 2023
a-thaler
added
area/documentation
|
@NHingerl @dennis-ge @a-thaler Please consider not using html tags for tabs. I introduced that plugin only to speed up migration from legacy website to docsify. This way we could render new website and old website from the same sources. As the old website is retired now we should use docsify syntax directly in the markdown files. Now we write in the old syntax and use magic regexp to convert it to the docsify syntax. Please change the documentation sources to the markdown syntax |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
div tabssections are broken in the telemetry module, e.g., https://kyma-project.io/#/telemetry-manager/user/03-traces?id=step-3a-add-authentication-details-from-plain-text or https://kyma-project.io/#/telemetry-manager/user/04-metrics?id=step-2b-add-authentication-details-from-secretsdiv tabssections to proper docsify-tabs sections is failing when the markdown sections are badly formatted. Badly formatted means that a\nor tab or whitespace is at the wrong placediv tabssections in feat: LogPipeline HTTP output mTLS support telemetry-manager#439div tabssections regex to docsify-tabs sectionsRelated issue(s)