Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure ORY Oathkeeper oauth2 default endpoints #18209

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

barchw
Copy link
Contributor

@barchw barchw commented Sep 21, 2023

Description

Hydra is deprecated since Kyma 2.2 and is planned to be removed in kyma 2.19. This PR configures ORY oathkeeper to non existing Hydra service. It is done like that because this configuration is mandatory for ORY oathkeeper to work. Users can still configure proper URLs on APIRule level and documentation is focused on that configuration.
Changes proposed in this pull request:

  • configure example default oauth2 URLs configuration

Related issue(s)

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2023
@netlify
Copy link

netlify bot commented Sep 21, 2023

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 3082ee6

@netlify
Copy link

netlify bot commented Sep 21, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 3082ee6
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/65112f36fb62770008c5f7dd
😎 Deploy Preview https://deploy-preview-18209--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 21, 2023
@strekm strekm changed the title Move hydra to deprecated namespace Configure ORY Oathkeeper oauth2 default endpoints Sep 21, 2023
@strekm strekm added area/api-gateway Issues or PRs related to api-gateway kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 21, 2023
@strekm strekm added this to the 2.19 milestone Sep 21, 2023
@kyma-bot kyma-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 21, 2023
@strekm strekm removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2023
@strekm strekm marked this pull request as ready for review September 22, 2023 11:58
@strekm strekm requested a review from a team as a code owner September 22, 2023 11:58
triffer
triffer previously approved these changes Sep 22, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 22, 2023
strekm
strekm previously approved these changes Sep 22, 2023
Copy link
Contributor

@strekm strekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@kyma-bot
Copy link
Contributor

@strekm: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@strekm
Copy link
Contributor

strekm commented Sep 22, 2023

depends on #18220

@strekm
Copy link
Contributor

strekm commented Sep 25, 2023

/test pre-main-kyma-integration-k3d

@barchw barchw dismissed stale reviews from strekm and triffer via 502f8b7 September 25, 2023 06:56
@barchw barchw requested review from a team as code owners September 25, 2023 06:56
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Sep 25, 2023
@triffer triffer self-requested a review September 25, 2023 08:05
@kyma-bot kyma-bot added the lgtm Looks good to me! label Sep 25, 2023
@kyma-bot kyma-bot merged commit 88fa123 into kyma-project:main Sep 25, 2023
4 checks passed
@barchw barchw deleted the hydra-dep branch September 25, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api-gateway Issues or PRs related to api-gateway kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants