Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace outdated blog links #18025

Merged
merged 3 commits into from
Aug 23, 2023
Merged

replace outdated blog links #18025

merged 3 commits into from
Aug 23, 2023

Conversation

NHingerl
Copy link
Contributor

@NHingerl NHingerl commented Aug 22, 2023

Description

Changes proposed in this pull request:

  • links to old blog posts are redirected to a useless target; replacing them with the files on GitHub instead

Related issue(s)

#18023

@NHingerl NHingerl requested a review from a team as a code owner August 22, 2023 12:40
@netlify
Copy link

netlify bot commented Aug 22, 2023

👷 Deploy request for kyma-project pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 5b7f4b0

@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 5b7f4b0
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/64e4b3b94d2d9600081c5cfc
😎 Deploy Preview https://deploy-preview-18025--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot kyma-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 22, 2023
@NHingerl NHingerl requested a review from a team as a code owner August 22, 2023 12:51
@NHingerl
Copy link
Contributor Author

Arrgh no, the link in the resource file should have been adjusted in the .go file and than populated with make manifests, right?

@kyma-bot kyma-bot added the lgtm Looks good to me! label Aug 22, 2023
@chrkl
Copy link
Contributor

chrkl commented Aug 22, 2023

/retest

2 similar comments
@chrkl
Copy link
Contributor

chrkl commented Aug 22, 2023

/retest

@NHingerl
Copy link
Contributor Author

/retest

@kyma-bot
Copy link
Contributor

kyma-bot commented Aug 22, 2023

@NHingerl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kyma-governance 5b7f4b0 link false /test pull-kyma-governance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot merged commit d90fd7d into kyma-project:main Aug 23, 2023
4 checks passed
@NHingerl NHingerl deleted the replace-outdated-blog-links branch August 24, 2023 08:39
@a-thaler a-thaler added kind/bug Categorizes issue or PR as related to a bug. area/documentation Issues or PRs related to documentation labels Aug 24, 2023
@a-thaler a-thaler added this to the 2.18 milestone Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Issues or PRs related to documentation kind/bug Categorizes issue or PR as related to a bug. lgtm Looks good to me! size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants