Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

record backend-errors with latency in epp #17802

Merged
merged 5 commits into from
Jul 10, 2023
Merged

record backend-errors with latency in epp #17802

merged 5 commits into from
Jul 10, 2023

Conversation

k15r
Copy link
Contributor

@k15r k15r commented Jul 6, 2023

Description

Changes proposed in this pull request:

  • record also metrics for failed calls to the backend

Related issue(s)

@k15r k15r requested a review from a team as a code owner July 6, 2023 13:02
@k15r k15r requested a review from muralov July 6, 2023 13:02
@k15r k15r added the area/eventing Issues or PRs related to eventing label Jul 6, 2023
@netlify
Copy link

netlify bot commented Jul 6, 2023 •
edited
Loading

✅ Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 1c56021
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/64a7fb872e40ea00087c06d9
😎 Deploy Preview https://deploy-preview-17802--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 6, 2023
@k15r
Copy link
Contributor Author

k15r commented Jul 6, 2023

/retest-required

muralov
muralov reviewed Jul 10, 2023
View reviewed changes
Copy link
Contributor

@muralov muralov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see in all cases code="500" eventing_epp_backend_requests_total{code="500",destination_service=""}, but wantStatus is different in some test cases.
Is this correct?
Is the case where backend http status code is none 500 tested?

@k15r
Copy link
Contributor Author

k15r commented Jul 10, 2023

I see in all cases code="500" eventing_epp_backend_requests_total{code="500",destination_service=""}, but wantStatus is different in some test cases. Is this correct? Is the case where backend http status code is none 500 tested?

this pr is just about the eventing_epp_backend_request_total to actually track errors. Presenting failed calls here with 500 is already an improvement. The HTTP Code used here is the one returned from the backend. In case of NATS we did some special handling of the error earlier to provide a meaningful return code to the caller. This will be synchronized later

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 10, 2023
@kyma-bot kyma-bot merged commit b406dab into kyma-project:main Jul 10, 2023
@k15r k15r linked an issue Jul 14, 2023 that may be closed by this pull request
Collect metrics in EPP for unsuccessful deliveries with active Jetstream backend #17547
Closed
pPrecel pushed a commit to pPrecel/kyma that referenced this pull request Jul 17, 2023
@k15r @pPrecel
record backend-errors with latency in epp (kyma-project#17802)
df72cec 
* record metrics for failed backend requests

* fix some previously missed tests

* bump image

* change image folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muralov muralov muralov approved these changes

Assignees

@muralov muralov

Labels
area/eventing Issues or PRs related to eventing lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collect metrics in EPP for unsuccessful deliveries with active Jetstream backend
3 participants
@k15r @muralov @kyma-bot