Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Loki #17751

Merged
merged 8 commits into from
Jul 5, 2023
Merged

Remove Loki #17751

merged 8 commits into from
Jul 5, 2023

Conversation

shorim
Copy link
Contributor

@shorim shorim commented Jun 27, 2023

Description

Changes proposed in this pull request:

  • Remove Loki resources.
  • Remove logging from components list.
  • Adjust docs for Loki removal.
  • Add migration script.

Related issue(s)

#17637

@shorim shorim added area/logging Issues or PRs related to the logging module (deprecated) do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jun 27, 2023
@shorim shorim requested review from a team as code owners June 27, 2023 11:21
@netlify
Copy link

netlify bot commented Jun 27, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit dfd420b
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/64a29949b59ea90008143e46
😎 Deploy Preview https://deploy-preview-17751--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kyma-bot kyma-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 27, 2023
@@ -112,7 +112,7 @@ To deploy Kyma with only specific components, run:
kyma deploy --components-file {COMPONENTS_FILE_PATH}
```

`{COMPONENTS_FILE_PATH}` is the path to a YAML file containing the desired component list to be installed. In the following example, only eight components are deployed on the cluster:
`{COMPONENTS_FILE_PATH}` is the path to a YAML file containing the desired component list to be installed. In the following example, only seven components are deployed on the cluster:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job for noticing this!!!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 😄

NHingerl
NHingerl previously approved these changes Jun 29, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jun 29, 2023
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jun 30, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 3, 2023
@shorim shorim removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2023
@shorim
Copy link
Contributor Author

shorim commented Jul 4, 2023

/test pre-main-kyma-integration-k3d-runtime-agent

5 similar comments
@shorim
Copy link
Contributor Author

shorim commented Jul 4, 2023

/test pre-main-kyma-integration-k3d-runtime-agent

@shorim
Copy link
Contributor Author

shorim commented Jul 4, 2023

/test pre-main-kyma-integration-k3d-runtime-agent

@shorim
Copy link
Contributor Author

shorim commented Jul 4, 2023

/test pre-main-kyma-integration-k3d-runtime-agent

@shorim
Copy link
Contributor Author

shorim commented Jul 5, 2023

/test pre-main-kyma-integration-k3d-runtime-agent

@shorim
Copy link
Contributor Author

shorim commented Jul 5, 2023

/test pre-main-kyma-integration-k3d-runtime-agent

@kyma-bot kyma-bot merged commit 7a87e04 into kyma-project:main Jul 5, 2023
pPrecel pushed a commit to pPrecel/kyma that referenced this pull request Jul 17, 2023
* remove Loki resources

* remove logging from components list

* adjust docs for loki removal

* remove Loki from dashboard

* add migration script

* adjust migration guide for Kyma 2.17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/logging Issues or PRs related to the logging module (deprecated) kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants