Add information on modular Kyma #17454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IwonaLanger
added
area/documentation
✅ Deploy Preview for kyma-project-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kyma-bot
added
the
size/XL
mmitoraj
previously approved these changes
May 8, 2023
varbanv
reviewed
May 8, 2023
NHingerl
reviewed
May 10, 2023
varbanv
previously approved these changes
May 10, 2023
|
/retest |
NHingerl
previously approved these changes
May 15, 2023
IwonaLanger
removed
the
do-not-merge/hold
…ger/kyma into Add_modularization_info
IwonaLanger
added
the
do-not-merge/hold
mmitoraj
approved these changes
Jun 28, 2023
IwonaLanger
removed
the
do-not-merge/hold
pbochynski
approved these changes
Jun 28, 2023
|
/retest |
chrkl
reviewed
Jun 28, 2023
| @@ -341,7 +341,7 @@ spec: | |||
| type: array | |||
| unsupportedMode: | |||
| description: Is active when the LogPipeline uses a `custom` output | |||
| or filter; see [unsupported mode](./../../01-overview/main-areas/telemetry/telemetry-02-logs.md#unsupported-mode#unsupported-mode). | |||
| or filter; see [unsupported mode](./../../01-overview/telemetry/telemetry-02-logs.md#unsupported-mode#unsupported-mode). | |||
There was a problem hiding this comment.
We should not use relative links in the CRD description since this is also used outside of the docs and will not work there. Can you fix this within this PR or should we create a follow-up PR?
There was a problem hiding this comment.
We should not use relative links in the CRD description since this is also used outside of the docs and will not work there. Can you fix this within this PR or should we create a follow-up PR?
TBH, I'd prefer to do it in another PR.
chrkl
approved these changes
Jun 28, 2023
|
/retest |
1 similar comment
|
/retest |
|
/test pre-main-kyma-integration-k3d-runtime-agent |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
#17210