Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the comments in Subscription v1alpha2. #17007

Conversation

friedrichwilken
Copy link
Contributor

@friedrichwilken friedrichwilken commented Mar 7, 2023

Description

Since all the hints in Busola are generated from our CRD, here is a little clean-up of the comments written in the underlying Go code. The main goal was to replace bebwith EventMesh. There are no functional changes to the code.

@friedrichwilken friedrichwilken requested a review from a team as a code owner March 7, 2023 09:37
@netlify
Copy link

netlify bot commented Mar 7, 2023

Deploy Preview for kyma-project-docs-preview ready!

Name Link
🔨 Latest commit 16560ab
🔍 Latest deploy log https://app.netlify.com/sites/kyma-project-docs-preview/deploys/640728aebbd188000762ac1b
😎 Deploy Preview https://deploy-preview-17007--kyma-project-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@friedrichwilken friedrichwilken added the area/eventing Issues or PRs related to eventing label Mar 7, 2023
@kyma-bot kyma-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 7, 2023
@friedrichwilken
Copy link
Contributor Author

/retest

@kyma-bot kyma-bot added the lgtm Looks good to me! label Mar 7, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Mar 7, 2023

@friedrichwilken: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pre-main-kyma-integration-k3d-runtime-agent 16560ab link false /test pre-main-kyma-integration-k3d-runtime-agent

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyma-bot kyma-bot merged commit c89af81 into kyma-project:main Mar 7, 2023
@friedrichwilken friedrichwilken self-assigned this Mar 7, 2023
@friedrichwilken friedrichwilken deleted the Cleanup-Subscription-v1alpha2-comments branch March 8, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/eventing Issues or PRs related to eventing lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants