This repository has been archived by the owner on Jul 4, 2024. It is now read-only.
Update json schema validator library #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbadura
added
the
kind/feature
dbadura
changed the title
dbadura
requested review from
akgalwas,
aszecowka,
crabtree,
franpog859,
janmedrek,
kfurgol,
Maladie,
PK85,
pkosiec and
Szymongib
as code owners
pkosiec
approved these changes
Sep 13, 2019
| @@ -187,3 +187,14 @@ func TestValidator_ValidateRaw(t *testing.T) { | |||
| }) | |||
| } | |||
| } | |||
|
|
|||
| // Test for this issue https://github.com/kyma-incubator/compass/issues/256 | |||
components/director/Gopkg.toml
Outdated
| @@ -21,7 +21,8 @@ required = [ | |||
|
|
|||
| [[constraint]] | |||
| name = "github.com/xeipuuv/gojsonschema" | |||
| version = "1.1.0" | |||
| # we fixed this library and this is the master commit with our fix | |||
There was a problem hiding this comment.
revision with fix for https://github.com/kyma-incubator/compass/issues/256
tgorgol
reviewed
Sep 13, 2019
components/director/Gopkg.toml
Outdated
| @@ -21,7 +21,8 @@ required = [ | |||
|
|
|||
| [[constraint]] | |||
| name = "github.com/xeipuuv/gojsonschema" | |||
| version = "1.1.0" | |||
| # we fixed this library and this is the master commit with our fix | |||
| revision = "6a016cf16650f6be7151db7c3be6fc90a2c4d9b1" | |||
There was a problem hiding this comment.
Suggested change
| revision = "6a016cf16650f6be7151db7c3be6fc90a2c4d9b1" | |
| revision = "6a016cf16650f6be7151db7c3be6fc90a2c4d9b1" |
tgorgol
approved these changes
Sep 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
jsonschemavalidatorlibrary with newest fix PRRelated issue(s)
See #256