Tests for connect over TLS were bypassed due to the unix socket path being populated #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
December 8, 2022 16:13
Remove secondary timer, openssl/stunnel config should give us the time padding clamd needs to boot
Others are variable...
All other messages seem either non-unique or too unique (only fired on a specific internal event)
Logs said clamav was already active...
added 9 commits
December 9, 2022 15:53
so it listens for both ipv6 & 4
carboneater
commented
Jan 5, 2023
kylefarris
added a commit
that referenced
this pull request
Mar 18, 2024
|
I've added the pertinent changes from this PR to Master. Thanks for the contribution @carboneater . I'll get the dependencies updated before the next release. |
This was referenced Sep 8, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I wanted to try to reproduce the CI errors regarding ClamAV sometimes returning an empty array.
I never managed to reproduce it locally.
However, I realized the TLS tests would pass, even when stunnel was stopped...
Overriding the default test values to force the right code branch uncovered two minor bugs...
And started a whole new round of fighting with GitHub Actions...
The two 30s timers in the pipeline were replaced with pauses until services are detected to be ready.
Sadly, even this did not fix the flakiness from the good files array test...