Removing String's deprecated APIs and modifying for Swift 4 #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would break Swift 3 compatibility wouldn't it? |
|
This doesn't break 3.2 compatibility, because this was valid and just warned for that version. I think that Xcode 8 support is already broken since the Package.swift is in tools version 4. @avinashdongarwar can you rebase here? |
|
You can see this still works with: |
|
Thanks for submitting this, this has been fixed as part of #48 and release as 0.9.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed use of
substring(from)api and updated for new syntax.