Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs this unreleased commit from
zstd-rs
, which was merged on Jan 28, and didn't make it into version0.10.0
.It also needs
default-features = false
onzstd
. That will be a change necessary inarrow-rs
. It looks like the only string ofzstd::
inarrow-rs
is inparquet/src/compression.rs
, and that seems to work fine withdefault-features=false
. So this update in Arrow shouldn't be an issue.Also needs to use the non-Apple
clang
for compiling. Ref rust-bitcoin/rust-secp256k1#283 (comment) and rust-bitcoin/rust-secp256k1#283 (comment) and the upstreamzstd
issue gyscos/zstd-rs#93. When onlyPATH
was updated but notCC
orAR
, I goterror: failed to build archive: section too large
.Repro: