Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use fsspec as ObjectStore backend #225

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

kylebarron
Copy link
Owner

@kylebarron kylebarron commented Oct 10, 2024

Of the required methods of the ObjectStore trait, they mostly seem pretty straightforward. I'd probably start with implementing delete, list, get_opts, and copy, and leave put_opts and especially put_multipart_opts for future work.

put_opts

Should be straightforward with put_file.

put_multipart_opts

Not sure if this one is really possible? At any rate, best to leave as todo!() and come back to later.

get_opts

This should be pretty easy to implement with cat_ranges

delete

Easy with _rm.

list

Should be possible with _ls.

Would need to ensure we can create an ObjectMeta out of the response.

  • Can we assume the response has a timestamp?

list_with_delimiter

Would need to create common_prefixes in the ListResult.

copy

Should be easy with copy

copy_if_not_exists

Not sure if fsspec has this natively, but we can fake it (subject to race conditions) by first checking exists.

get_ranges

ObjectStore::get_ranges is not a required trait method, but we could implement it if we want the coalescing to happen on the fsspec side rather than the object-store side.

cc @martindurant

@kylebarron kylebarron changed the title wip pyo3-object-store wip use fsspec as ObjectStore backend Oct 10, 2024
@kylebarron kylebarron changed the title wip use fsspec as ObjectStore backend use fsspec as ObjectStore backend Oct 10, 2024
@kylebarron kylebarron marked this pull request as draft October 10, 2024 22:52
@kylebarron
Copy link
Owner Author

This should be moved to https://github.com/developmentseed/object-store-rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant