-
-
Notifications
You must be signed in to change notification settings - Fork 745
Check Egg Move combinations for a valid father #4444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Will post comment reply with observations
Potential observations/insights:
Historically, the egg-chain theorycrafting was done by dumping a list of Move->species[]. This approach might be useful, if we also want to precompute seedpoke[species] (baby eggs from current species) and (group1, group2)[species]. We're already doing the work when the node list is built... so if we only have to do some of the work once and keep a global copy... Maybe a rent on |
In Gen 2-5, no species has a different gender ratio or Egg Groups between forms. Only Wormadam has a different learnset between forms, but it can't be a father to pass on any moves it learns and Burmy has no Egg Moves.
The Egg Move lists are supposed to only include possible Egg Moves Remove impossible Egg Moves in GS: - Bulbasaur, Oddish, Snorlax (Charm) - Staryu (Aurora Beam, Barrier, Supersonic) - Smoochum (Lovely Kiss)
1-3 and 6 should be addressed for now, the rest I'll try to get to another day. For 2, I'll note that only inherited level-up moves are currently considered, since it's only directly checking movesets in the current generation anyway (past-gen TMs are handled through attempted encounter generation for now). For 3, there were some impossible Egg Moves in GS that needed to be removed:
For 5, Bulbapedia and Showdown claim that depending on the game, certain moves (Mirror Move, Sleep Talk, Transform, Metronome, Mimic, Self-Destruct and Explosion) also can't be Sketched. They don't agree on whether Mirror Move or Sleep Talk can't be Sketched or not in Gen 3-5 though (Bulbapedia claims they can't, Showdown claims they can). |
stackalloc, rearrange early checks
Closes #4426
One of the existing test cases appears to have an invalid combination based on this check. This Gen2 Oddish has Flail/Razor Leaf/Swords Dance/Synthesis.